open() of device special files

Commit Message

J. Bruce Fields Aug. 16, 2011, 11:03 a.m. UTC

On Mon, Aug 15, 2011 at 10:04:29PM -0700, Myklebust, Trond wrote:
> > -----Original Message-----
> > From: J. Bruce Fields [mailto:[e-mail]]
> > And the change also makes a bunch of pynfs tests fail, complaining
> that
> > various operations against incompatible types should have returned
> > INVAL
> > and not SYMLINK.
> > 
> > Not that I'm convinced pynfs is correct--at the very least it should
> > have accepted a range of errors for those tests, I think--but anyone
> > else that ran pynfs against their server may have assumed it pynfs was
> > correct in these cases....
> 
> Pynfs is not an authoritative source for anything.

We should say that, for what it's worth.  (Below.)

But it's just another reason why servers may have been written to return
something other than err_symlink....  I have in the past had to tell
developers of more than one server that fixing error returns to make
pynfs happy may not be a good idea.

--b.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/README b/README
index 0c34b2a..ecb2aa6 100644
--- a/README
+++ b/README
@@ -12,3 +12,9 @@  in place.
 For more details about 4.0 and 4.1 testing, see nfs4.0/README and
 nfs4.1/README, respectively.  For information about automatic code
 generation from an XDR file, see xdr/README.
+
+Note that test results should *not* be considered authoritative
+statements about the protocol--if you find that a server fails a test,
+you should consult the rfc's and think carefully before assuming that
+the server is at fault.  (However, we do appreciate patches if you
+find a test that requires incorrect behavior.)