| Message ID | 20120731143600.GD27834@fieldses.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 31, 2012 at 7:36 AM, J. Bruce Fields <bfields@fieldses.org> wrote: > > By the way, for a few years now I've been semi-regularly picking up > locks.c changes for my tree. I wonder if I should be. I really wish you didn't. Or at least not this way. For example, now you removed that lm_release_private case, but you did that without apparently talking to any VFS maintainers. And the commit seems to be pure shit. Why is it pure shit? Look at what users are left. THERE ARE NO USERS THAT SET THAT FIELD ANY MORE! Maybe I missed some odd user that somehow avoids the grep, but I don't think so. So there is nothing that ever sets it, why the hell does the thing still remain at all? So if this is a real bugfix, then I think it damn well should (a) at a minimum have been discussed with VFS maintainers (b) have been thought through a bit more (ie remove all remains of that now useless lm_release_private field) (c) likely never have gone through the NFSD tree in any case. I've pulled the changes for now, but I absolutely *detest* seeing things like this. I care very little about the nfsd code, but I care deeply when I see insanity happening in the VFS layer. And right now, "lm_release_private" is insane as of this pull. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/MAINTAINERS b/MAINTAINERS index 3e30a3a..305ac2c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2767,15 +2767,6 @@ F: include/scsi/fc/ F: include/scsi/libfc.h F: include/scsi/libfcoe.h -FILE LOCKING (flock() and fcntl()/lockf()) -M: Matthew Wilcox <matthew@wil.cx> -L: linux-fsdevel@vger.kernel.org -S: Maintained -F: include/linux/fcntl.h -F: include/linux/fs.h -F: fs/fcntl.c -F: fs/locks.c - FILESYSTEMS (VFS and infrastructure) M: Alexander Viro <viro@zeniv.linux.org.uk> L: linux-fsdevel@vger.kernel.org
On Tue, Jul 31, 2012 at 10:29:48AM -0400, bfields wrote: > Please pull nfsd (and some lockd and a couple locks/lease) changes from: By the way, for a few years now I've been semi-regularly picking up locks.c changes for my tree. I wonder if I should be. At the least we should probably remove this entry from MAINTAINERS? And by default I suppose that stuff reverts to Al, who rumor has it will have a fair number of locks.c patches next time around. Or I'm happy to claim to be maintainer of that file if somebody prefers, it doesn't matter much to me. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html