From patchwork Tue Jan 8 12:13:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King X-Patchwork-Id: 1945371 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 6EE013FED4 for ; Tue, 8 Jan 2013 12:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155Ab3AHMNL (ORCPT ); Tue, 8 Jan 2013 07:13:11 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:41947 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756030Ab3AHMNK (ORCPT ); Tue, 8 Jan 2013 07:13:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date; bh=mVE511XLuqQYaszjaOdB6bYUYlnBaeyvtpG987+RBeM=; b=ZTikbd7QdpGkYSDqJp0J7g81LvTuBQ+aVgK2gN98EryWF5Fi3oByuXSoc5lGB+gJFit18203w6eDoQDLkT7czNjpmRtE42Eq2k6VX15ouS/Ju/iKGBr8TnRM2Vk62J+4V0glJIPlCEI2UeOA6kO+auoQSbhWT0B7udpYESp6PmU=; Received: from flint.arm.linux.org.uk ([2002:4e20:1eda:1:201:2ff:fe14:8fad]:43920) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1TsY3D-0008C3-GD; Tue, 08 Jan 2013 12:13:03 +0000 Received: from rmk by flint.arm.linux.org.uk with local (Exim 4.69) (envelope-from ) id 1TsY3B-0001on-HI; Tue, 08 Jan 2013 12:13:01 +0000 Date: Tue, 8 Jan 2013 12:13:00 +0000 From: Russell King To: "J. Bruce Fields" Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Commit 7032a3dd9 (svcrpc: demote some printks to a dprintk) adds warnings Message-ID: <20130108121300.GA2251@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Bruce, Your commit below causes a new build warning in the kernel: net/sunrpc/svc.c: In function 'svc_printk': net/sunrpc/svc.c:1050:7: warning: unused variable 'buf' which affects all ARM builds; it is the only warning in a lot of cases. Please can you resolve this new warning using whatever method you feel is most appropriate, thanks. commit 7032a3dd923f434132643321ad5faad128611f9e Author: J. Bruce Fields Date: Tue Oct 9 18:33:38 2012 -0400 svcrpc: demote some printks to a dprintk In general I'd rather random bad behavior on the network won't trigger a printk. Signed-off-by: J. Bruce Fields diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index 3ee7461..be301e1 100644 --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c @@ -1035,7 +1035,7 @@ static void svc_unregister(const struct svc_serv *serv, struct net *net) } /* - * Printk the given error with the address of the client that caused it. + * dprintk the given error with the address of the client that caused it. */ static __printf(2, 3) void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...) @@ -1049,8 +1049,7 @@ void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...) vaf.fmt = fmt; vaf.va = &args; - net_warn_ratelimited("svc: %s: %pV", - svc_print_addr(rqstp, buf, sizeof(buf)), &vaf); + dprintk("svc: %s: %pV", svc_print_addr(rqstp, buf, sizeof(buf)), &vaf); va_end(args); }