From patchwork Tue May 14 21:03:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 2568601 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id CCB743FD85 for ; Tue, 14 May 2013 21:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758428Ab3ENVDn (ORCPT ); Tue, 14 May 2013 17:03:43 -0400 Received: from fieldses.org ([174.143.236.118]:35226 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758419Ab3ENVDn (ORCPT ); Tue, 14 May 2013 17:03:43 -0400 Received: from bfields by fieldses.org with local (Exim 4.76) (envelope-from ) id 1UcMNq-0004Kc-Kq for linux-nfs@vger.kernel.org; Tue, 14 May 2013 17:03:42 -0400 Date: Tue, 14 May 2013 17:03:42 -0400 To: linux-nfs@vger.kernel.org Subject: [PATCH] sunrpc: server back channel needs no rpcbind method Message-ID: <20130514210342.GJ1931@fieldses.org> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) From: "J. Bruce Fields" Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: "J. Bruce Fields" XPRT_BOUND is set on server backchannel xprts by xs_setup_bc_tcp() (using xprt_set_bound()), and is never cleared, so ->rpcbind() will never need to be called. Reported-by: "Myklebust, Trond" Signed-off-by: J. Bruce Fields --- net/sunrpc/xprtsock.c | 1 - 1 file changed, 1 deletion(-) Trond pointed this out once, then the patch got lost for some reason. Applying for 3.11.--b. diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index ffd5034..5d6b0da 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -2534,7 +2534,6 @@ static struct rpc_xprt_ops bc_tcp_ops = { .reserve_xprt = xprt_reserve_xprt, .release_xprt = xprt_release_xprt, .alloc_slot = xprt_alloc_slot, - .rpcbind = xs_local_rpcbind, .buf_alloc = bc_malloc, .buf_free = bc_free, .send_request = bc_send_request,