From patchwork Fri Aug 1 16:48:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 4663871 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3E2F0C0338 for ; Fri, 1 Aug 2014 16:48:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 67286201FE for ; Fri, 1 Aug 2014 16:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 253F1201FB for ; Fri, 1 Aug 2014 16:48:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753946AbaHAQss (ORCPT ); Fri, 1 Aug 2014 12:48:48 -0400 Received: from fieldses.org ([174.143.236.118]:40642 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbaHAQsr (ORCPT ); Fri, 1 Aug 2014 12:48:47 -0400 Received: from bfields by fieldses.org with local (Exim 4.76) (envelope-from ) id 1XDG0Z-00006Q-DH; Fri, 01 Aug 2014 12:48:43 -0400 Date: Fri, 1 Aug 2014 12:48:43 -0400 From: "J. Bruce Fields" To: Jeff Layton Cc: linux-nfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH v3 21/38] nfsd: Add reference counting to state owners Message-ID: <20140801164843.GB32749@fieldses.org> References: <1406684083-19736-1-git-send-email-jlayton@primarydata.com> <1406684083-19736-22-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1406684083-19736-22-git-send-email-jlayton@primarydata.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jul 29, 2014 at 09:34:26PM -0400, Jeff Layton wrote: > struct nfs4_stateowner { > - struct list_head so_strhash; /* hash by op_name */ > - struct list_head so_stateids; > - struct nfs4_client * so_client; > + struct list_head so_strhash; > + struct list_head so_stateids; > + struct nfs4_client *so_client; > + const struct nfs4_stateowner_operations *so_ops; > /* after increment in ENCODE_SEQID_OP_TAIL, represents the next > * sequence id expected from the client: */ Uh, that could use updating--applying below. Anyway, the stateowner reference counting makes sense to me. --b. commit 84a46922ea90 Author: J. Bruce Fields Date: Thu Jul 31 16:10:08 2014 -0400 nfsd4: fix out of date comment Signed-off-by: J. Bruce Fields Acked-by: Jeff Layton --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h index 73a209dc352b..0b234500f104 100644 --- a/fs/nfsd/state.h +++ b/fs/nfsd/state.h @@ -345,7 +345,7 @@ struct nfs4_stateowner { struct list_head so_stateids; struct nfs4_client *so_client; const struct nfs4_stateowner_operations *so_ops; - /* after increment in ENCODE_SEQID_OP_TAIL, represents the next + /* after increment in nfsd4_bump_seqid, represents the next * sequence id expected from the client: */ atomic_t so_count; u32 so_seqid;