From patchwork Fri May 8 22:34:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thorsten Kukuk X-Patchwork-Id: 6367921 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9766EBEEE1 for ; Fri, 8 May 2015 22:34:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C7132202FF for ; Fri, 8 May 2015 22:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B630F202EC for ; Fri, 8 May 2015 22:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbbEHWeO (ORCPT ); Fri, 8 May 2015 18:34:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56312 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981AbbEHWeO (ORCPT ); Fri, 8 May 2015 18:34:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EE4ADAB5F; Fri, 8 May 2015 22:34:12 +0000 (UTC) Date: Sat, 9 May 2015 00:34:12 +0200 From: Thorsten Kukuk To: Steve Dickson Cc: libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org Subject: Re: [PATCH V2] Fix Build w/gssapi disabled Message-ID: <20150508223412.GA14634@suse.de> References: <554B86E2.8090908@RedHat.com> <20150507163326.GA6156@suse.de> <554B98E9.4040601@RedHat.com> <20150507181206.GA7810@suse.de> <554BC53C.5080807@RedHat.com> <554BC730.3000004@RedHat.com> <554BC9F3.6020005@RedHat.com> <20150508020322.GF30924@vapier> <20150508081717.GA16376@suse.de> <554D2A4B.6040307@RedHat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <554D2A4B.6040307@RedHat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY,URIBL_DBL_ABUSE_REDIR autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, May 08, Steve Dickson wrote: > Hello Thorsten, > > On 05/08/2015 04:17 AM, Thorsten Kukuk wrote: > > On Thu, May 07, Mike Frysinger wrote: > > > >> it is dangerous to export raw HAVE_xxx defines -- it can break packages that > >> use autotools themselves. they need an appropriate prefix like RPC_xxx or > >> TIRPC_xxx. > > > > > > For this and to solve the different size of the struct, I created > > a new patch on top of current git. I only had to rearange the structs > > a little bit, since they don't use any kerberos specific variables, > > only standard C: > I applied the following patch to the top of the git tree > then I yum remove krb5-devel (which removes gssapi/gssapi.h) > > After an 'sh autogen.sh' and ./configure --disable-gssapi > I'm getting the following compile errors > http://ur1.ca/kbq67 > because gssapi.h does not exist.. > > What am I doing wrong?? Sorry, somehow my patch was incomplete, this part did go missing: diff --git a/tirpc/rpc/rpcsec_gss.h b/tirpc/rpc/rpcsec_gss.h index 217fc0d..f02de8a 100644 --- a/tirpc/rpc/rpcsec_gss.h +++ b/tirpc/rpc/rpcsec_gss.h @@ -35,8 +35,6 @@ #include #include -#include - typedef enum { rpcsec_gss_svc_default = 0, rpcsec_gss_svc_none = 1,