diff mbox

Pull request for pynfs

Message ID 20151019214801.GA16551@fieldses.org (mailing list archive)
State New, archived
Headers show

Commit Message

J. Bruce Fields Oct. 19, 2015, 9:48 p.m. UTC 
On Fri, Oct 16, 2015 at 01:44:42PM -0700, Frank Filz wrote:
> Bruce,
> 
> Please pull the top patch from:
> 
> https://github.com/ffilz/pynfs/commits/master
> 
> It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different principal
> replaces a clientid that has no state, and adds CID2a which expects
> NFS4ERR_CLID_INUSE since it does have state.

Thanks!

This leave us with two test functions both named "testInUse".

I applied the following to get both tests working.

--b.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Frank Filz Oct. 19, 2015, 10 p.m. UTC | #1 
> On Fri, Oct 16, 2015 at 01:44:42PM -0700, Frank Filz wrote:
> > Bruce,
> >
> > Please pull the top patch from:
> >
> > https://github.com/ffilz/pynfs/commits/master
> >
> > It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different
> > principal replaces a clientid that has no state, and adds CID2a which
> > expects NFS4ERR_CLID_INUSE since it does have state.
> 
> Thanks!
> 
> This leave us with two test functions both named "testInUse".
> 
> I applied the following to get both tests working.

Oops, sorry...

Frank

> diff --git a/nfs4.0/servertests/st_setclientid.py
> b/nfs4.0/servertests/st_setclientid.py
> index 0fb59cd7f542..fbeab22e5026 100644
> --- a/nfs4.0/servertests/st_setclientid.py
> +++ b/nfs4.0/servertests/st_setclientid.py
> @@ -50,7 +50,7 @@ def testClientUpdateCallback(t, env):
>      res = c.close_file(t.code, fh, stateid)
>      check(res, msg="Close after updating callback info")
> 
> -def testInUse(t, env):
> +def testNotInUse(t, env):
>      """SETCLIENTID with same nfs_client_id.id should return NFS4ERR_OK
>         if there is no active state
> 


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/nfs4.0/servertests/st_setclientid.py b/nfs4.0/servertests/st_setclientid.py
index 0fb59cd7f542..fbeab22e5026 100644
--- a/nfs4.0/servertests/st_setclientid.py
+++ b/nfs4.0/servertests/st_setclientid.py
@@ -50,7 +50,7 @@  def testClientUpdateCallback(t, env):
     res = c.close_file(t.code, fh, stateid)
     check(res, msg="Close after updating callback info")
     
-def testInUse(t, env):
+def testNotInUse(t, env):
     """SETCLIENTID with same nfs_client_id.id should return NFS4ERR_OK
        if there is no active state