From patchwork Mon Feb 15 15:23:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 8316051 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C6052C02AA for ; Mon, 15 Feb 2016 15:24:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DD54B203B8 for ; Mon, 15 Feb 2016 15:24:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A2AA2037C for ; Mon, 15 Feb 2016 15:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751592AbcBOPYS (ORCPT ); Mon, 15 Feb 2016 10:24:18 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:38612 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbcBOPYC (ORCPT ); Mon, 15 Feb 2016 10:24:02 -0500 Received: by mail-ig0-f181.google.com with SMTP id y8so56945888igp.1 for ; Mon, 15 Feb 2016 07:24:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=Wee6D16kMyycYKJPYsS252B224BUphcroD9ovHxV16o=; b=kmAdpRZSpotvG5NnIoGmKW7aByS4MQVwCUdaZiAb2ASVjfaXoH3NMoFJHnatblYfnE 1T0bfClULXKHJ8jznGafZB72b9iGiHaFQSiw8gXsFGgPRYlesSd4VYAtQl8tgXR9v7e8 gY/uEL6aQ6Cnfer+k18n51WMxasGxIk4lAJ2f1TNgykhlCa5R/2SNIUTBSEzVNH+/GF+ xwC6Y0NTspoh08YlBBEWKe4gdnr/j2Gw2xaqdfSSsFgxjSZZnIglXPi9sVzypWkh4Gf1 xRvzGShLdn3z0OkiR5SBJAX6VZR8xyiHaIDr9tRtQsIpcNGu6MhBUEAZSglN16Iuan8J a4iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=Wee6D16kMyycYKJPYsS252B224BUphcroD9ovHxV16o=; b=BNLfukssqmBhZPX8fw87IG8J8Gq+I8xvFavCU/RakrrxzXTkQvRGGyn2ro/STRHa88 NPzjEkhyopksOtc7JD6+dCX75F9Puj055tUpHa4Vt5/ox1Q3poiuX2DAzgm1wqdemEP1 80bjKAGzw5ZE3M1gs2rNkRx6ClAt2D2FYmYSK+VYHCvMJ99zhSYrTuP0drnnyl3yp+ib OTbRfznzsuxRaTKMlxAzxRewqF4tbzd2wos1T2JpnN6ftdNfZthAMeZnzBvJcHPjNoWP a0akcAkTLw991gEFqciY4GAVAUuijknV11UPDFRZmDTSjgwqC+SSETG7bRnpIIKhJkzu Sx3w== X-Gm-Message-State: AG10YOSfmngVjPC9W2kp9mmLdYw6rL6HfdKd21EhpVpmIXbUSxsCCLPeWWtMFSlkkiz09Q== X-Received: by 10.50.88.74 with SMTP id be10mr13116370igb.93.1455549841161; Mon, 15 Feb 2016 07:24:01 -0800 (PST) Received: from manet.1015granger.net ([2604:8800:100:81fc:ec4:7aff:fe6c:1dce]) by smtp.gmail.com with ESMTPSA id wj3sm6896677igb.6.2016.02.15.07.24.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Feb 2016 07:24:00 -0800 (PST) Subject: [PATCH] xprtrdma: rpcrdma_bc_receive_call() should init rq_private_buf.len From: Chuck Lever To: anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org Date: Mon, 15 Feb 2016 10:23:59 -0500 Message-ID: <20160215152040.22738.95129.stgit@manet.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some NFSv4.1 OPEN requests were hanging waiting for the NFS server to finish recalling delegations. Turns out that each NFSv4.1 CB request on RDMA gets a GARBAGE_ARGS reply from the Linux client. Commit 756b9b37cfb2e3dc added a line in bc_svc_process that overwrites the incoming rq_rcv_buf's length with the value in rq_private_buf.len. But rpcrdma_bc_receive_call() does not invoke xprt_complete_bc_request(), thus rq_private_buf.len is not initialized. svc_process_common() is invoked with a zero-length RPC message, and fails. Fixes: 756b9b37cfb2e3dc ('SUNRPC: Fix callback channel') Signed-off-by: Chuck Lever --- Hi Anna- Commit 756b9b37cfb2e3dc in v4.5-rc1 introduced a behavior regression for NFSv4.1-over-RDMA. Would it be possible to merge this bug fix into 4.5-rc ? net/sunrpc/xprtrdma/backchannel.c | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/backchannel.c b/net/sunrpc/xprtrdma/backchannel.c index cc1251d..2dcd764 100644 --- a/net/sunrpc/xprtrdma/backchannel.c +++ b/net/sunrpc/xprtrdma/backchannel.c @@ -341,6 +341,8 @@ void rpcrdma_bc_receive_call(struct rpcrdma_xprt *r_xprt, rqst->rq_reply_bytes_recvd = 0; rqst->rq_bytes_sent = 0; rqst->rq_xid = headerp->rm_xid; + + rqst->rq_private_buf.len = size; set_bit(RPC_BC_PA_IN_USE, &rqst->rq_bc_pa_state); buf = &rqst->rq_rcv_buf;