From patchwork Wed May 4 14:53:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 9015441 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id ECF319F30C for ; Wed, 4 May 2016 14:53:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2406E203AB for ; Wed, 4 May 2016 14:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F110203AA for ; Wed, 4 May 2016 14:53:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbcEDOxZ (ORCPT ); Wed, 4 May 2016 10:53:25 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:35054 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcEDOxY (ORCPT ); Wed, 4 May 2016 10:53:24 -0400 Received: by mail-ig0-f175.google.com with SMTP id bi2so149999951igb.0; Wed, 04 May 2016 07:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=yxMalVvNPei9lNlFRPsPlDLNBBnlBbPnbsHcwzCP61U=; b=GeyLTYdO5LT9p/AVC5BriCNBuagXFHRTBxVbV6bDvR/uaoOIbb4ddkgco8q61ZFlCs f528iRCL/WkmNgzggDwO8LxwrlLo0JTgOfbTUfxICfDJz1DTCBlNY6xJWI2kH7U8kd2y +/43U4n4pe5bYIF32YtBijyGeQHK3hq2GpND5wfjPt2NnY0zH9Uc7Tvv46AIOX9gWbK2 kngMNys02iKHTgDkJnoVHANz2I5s0xm3vvybJJxgBxuQDYl3b3N7+OThzre1tK8ZXzGs y6Nq44qrriaNXw6axWK3ck6eXkEoEjDjiBgf3bXIbY8+RjyAm4aZYJrKNgxRnC22uF8A VE3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=yxMalVvNPei9lNlFRPsPlDLNBBnlBbPnbsHcwzCP61U=; b=OQzibtK/ffZn/byNG2YY66c7AAXTed3/UFj8iHT69UGSV1S9E+ksd5CEUOp28ErEAZ LhmgfoGSx/CVB74JNY7rUbzT32uESFI8RoTLccbRBJHAZKmRc0DM3QZqwC8u4JxN5NYB TQbylTpCMf3kbupScfEZ4s91anzHT8L+cQBtQBFAsnWTuf5QzdMeTqnHcBYFqCHS7E1+ +pi/Wphtd9XQbE8JGAi34tBa+pZHyc989xEV+GdOchyyJo4RPfSad348p+CzMV/4GwHA 1to2MPJh9fS25gjEQFQQdF3Um2XIR6Kc58S8BE9jB/CrlzZaH+dkboSiv5E34VXqNUlb 63Ww== X-Gm-Message-State: AOPr4FUIPfARgBLEyu+l3teOjBZKYHhCzA4RI6FSkAtmi+rvq8pI7y+R7WKAb+0fd+B0yg== X-Received: by 10.50.187.133 with SMTP id fs5mr33838836igc.61.1462373603459; Wed, 04 May 2016 07:53:23 -0700 (PDT) Received: from klimt.1015granger.net ([2604:8800:100:81fc:ec4:7aff:fe6c:6aa0]) by smtp.gmail.com with ESMTPSA id g186sm1439676iof.27.2016.05.04.07.53.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 May 2016 07:53:23 -0700 (PDT) Subject: [PATCH v2 5/9] svcrdma: Post Receives only for forward channel requests From: Chuck Lever To: bfields@fieldses.org Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Date: Wed, 04 May 2016 10:53:22 -0400 Message-ID: <20160504145322.6602.71848.stgit@klimt.1015granger.net> In-Reply-To: <20160504144730.6602.89073.stgit@klimt.1015granger.net> References: <20160504144730.6602.89073.stgit@klimt.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since backward direction support was added, the rq_depth was increased to accommodate both forward and backward Receives. But only forward Receives need to be posted after a connection has been accepted. Receives for backward replies are posted as needed by svc_rdma_bc_sendto(). This doesn't break anything, but it means some resources are wasted. Fixes: 03fe9931536f ('svcrdma: Define maximum number of ...') Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index d2680b8..02a112c 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -1083,7 +1083,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) newxprt->sc_dev_caps |= SVCRDMA_DEVCAP_READ_W_INV; /* Post receive buffers */ - for (i = 0; i < newxprt->sc_rq_depth; i++) { + for (i = 0; i < newxprt->sc_max_requests; i++) { ret = svc_rdma_post_recv(newxprt, GFP_KERNEL); if (ret) { dprintk("svcrdma: failure posting receive buffers\n");