From patchwork Mon Mar 27 14:05:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 9646817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5935F602D6 for ; Mon, 27 Mar 2017 14:07:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4BF1A28405 for ; Mon, 27 Mar 2017 14:07:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F26328423; Mon, 27 Mar 2017 14:07:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE6212841C for ; Mon, 27 Mar 2017 14:07:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbdC0OH2 (ORCPT ); Mon, 27 Mar 2017 10:07:28 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:33981 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbdC0OGL (ORCPT ); Mon, 27 Mar 2017 10:06:11 -0400 Received: by mail-it0-f68.google.com with SMTP id e75so4448625itd.1; Mon, 27 Mar 2017 07:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=XVB9aPiE2JYk4JPtxShlmaQPdPv39iiEyLlHkBMWu4Q=; b=RulkezXtpn4lwOSgu+I5FLSk9Q+WxxwWND58YHhR97gAl3w5M/FxUaklhxWCxV2klF s8KCnawv83cmzrYprEGhi5GpCB3IP9jPaYm5GYwjT0zOnm6sN3/WxCnDknf0yuuT7U5v sEjpg/0bo+uZaovvwAugJoR/XMDCZDm2SZveC1227ZTZ/IT9qGQ1HcPyIuWqXQTzdWxR MVXKnA+qIMukA60j8wavXPn9RI0O/ZK7/o/aCJlX17Sno+mOgSe+tAh1VYDfk+jr367Y 8s7FMQa0qpMQW3gY9kr4PVzGmAJZGeVrhnq7UJSjcJ9L2jPFwPqjqb2KGSJS65NFG5MG 9FIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=XVB9aPiE2JYk4JPtxShlmaQPdPv39iiEyLlHkBMWu4Q=; b=Dw/psB0QHSz9BoeKzhnsfPn2UrlvPfjwepbVNQSQP+QTdSxSt8A95x0cjNAAGxS2oB ejLyP++nKgHdZaYl+K65H7yjAgZPwTMAPOYRnYH83PbqETM0U+tg9wwo3YbY97c//Wem UZLh/UsNC/hKjrCh9je+VpHhQCDdld7ifQAOaz3aY3S/91SN6VVBQ+K+5ILbJU0vOqVr y/1qg3qQnab2luRffwqql6dsBEvsDI3FhCNAqW5lZ0DUeNr6+YoOL1VWZFba/9GMarcM /0j3GLQ4BU9AXMz6rnAY3bakzg0elddzVIvGrlZrAaa/jbSfWLx1TD9k9k6BjzrHOwk/ Effg== X-Gm-Message-State: AFeK/H1tIbsHeLhpn8KlX/R8rUG1P97zLhSYD0nK8+5jnH1DszVCyYIhUmXdltWW/O3DcQ== X-Received: by 10.36.215.194 with SMTP id y185mr10397284itg.101.1490623544432; Mon, 27 Mar 2017 07:05:44 -0700 (PDT) Received: from manet.1015granger.net (c-68-46-169-226.hsd1.mi.comcast.net. [68.46.169.226]) by smtp.gmail.com with ESMTPSA id p198sm278435itg.31.2017.03.27.07.05.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 07:05:43 -0700 (PDT) Subject: [PATCH v2 01/13] xprtrdma: Cancel refresh worker during buffer shutdown From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Date: Mon, 27 Mar 2017 10:05:43 -0400 Message-ID: <20170327140543.20813.66981.stgit@manet.1015granger.net> In-Reply-To: <20170327134847.20813.52412.stgit@manet.1015granger.net> References: <20170327134847.20813.52412.stgit@manet.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Trying to create MRs while the transport is being torn down can cause a crash. Fixes: e2ac236c0b65 ("xprtrdma: Allocate MRs on demand") Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/verbs.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index 3b332b3..2e4fc1e 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -1037,6 +1037,7 @@ struct rpcrdma_rep * rpcrdma_buffer_destroy(struct rpcrdma_buffer *buf) { cancel_delayed_work_sync(&buf->rb_recovery_worker); + cancel_delayed_work_sync(&buf->rb_refresh_worker); while (!list_empty(&buf->rb_recv_bufs)) { struct rpcrdma_rep *rep;