| Message ID | 20170509154930.29524-6-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue 09-05-17 11:49:08, Jeff Layton wrote: > Nothing checks its return value. > > Signed-off-by: Jeff Layton <jlayton@redhat.com> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/btrfs/disk-io.c | 6 +++--- > fs/btrfs/disk-io.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > index eb1ee7b6f532..8c479bd5534a 100644 > --- a/fs/btrfs/disk-io.c > +++ b/fs/btrfs/disk-io.c > @@ -1222,10 +1222,10 @@ int btrfs_write_tree_block(struct extent_buffer *buf) > buf->start + buf->len - 1); > } > > -int btrfs_wait_tree_block_writeback(struct extent_buffer *buf) > +void btrfs_wait_tree_block_writeback(struct extent_buffer *buf) > { > - return filemap_fdatawait_range(buf->pages[0]->mapping, > - buf->start, buf->start + buf->len - 1); > + filemap_fdatawait_range(buf->pages[0]->mapping, > + buf->start, buf->start + buf->len - 1); > } > > struct extent_buffer *read_tree_block(struct btrfs_fs_info *fs_info, u64 bytenr, > diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h > index 2e0ec29bfd69..9cc87835abb5 100644 > --- a/fs/btrfs/disk-io.h > +++ b/fs/btrfs/disk-io.h > @@ -127,7 +127,7 @@ int btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct inode *inode, > extent_submit_bio_hook_t *submit_bio_done); > unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info); > int btrfs_write_tree_block(struct extent_buffer *buf); > -int btrfs_wait_tree_block_writeback(struct extent_buffer *buf); > +void btrfs_wait_tree_block_writeback(struct extent_buffer *buf); > int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans, > struct btrfs_fs_info *fs_info); > int btrfs_add_log_tree(struct btrfs_trans_handle *trans, > -- > 2.9.3 > >
On Tue, May 09, 2017 at 11:49:08AM -0400, Jeff Layton wrote: > Nothing checks its return value. Reviewed-by: Liu Bo <bo.li.liu@oracle.com> -liubo > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > --- > fs/btrfs/disk-io.c | 6 +++--- > fs/btrfs/disk-io.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > index eb1ee7b6f532..8c479bd5534a 100644 > --- a/fs/btrfs/disk-io.c > +++ b/fs/btrfs/disk-io.c > @@ -1222,10 +1222,10 @@ int btrfs_write_tree_block(struct extent_buffer *buf) > buf->start + buf->len - 1); > } > > -int btrfs_wait_tree_block_writeback(struct extent_buffer *buf) > +void btrfs_wait_tree_block_writeback(struct extent_buffer *buf) > { > - return filemap_fdatawait_range(buf->pages[0]->mapping, > - buf->start, buf->start + buf->len - 1); > + filemap_fdatawait_range(buf->pages[0]->mapping, > + buf->start, buf->start + buf->len - 1); > } > > struct extent_buffer *read_tree_block(struct btrfs_fs_info *fs_info, u64 bytenr, > diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h > index 2e0ec29bfd69..9cc87835abb5 100644 > --- a/fs/btrfs/disk-io.h > +++ b/fs/btrfs/disk-io.h > @@ -127,7 +127,7 @@ int btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct inode *inode, > extent_submit_bio_hook_t *submit_bio_done); > unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info); > int btrfs_write_tree_block(struct extent_buffer *buf); > -int btrfs_wait_tree_block_writeback(struct extent_buffer *buf); > +void btrfs_wait_tree_block_writeback(struct extent_buffer *buf); > int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans, > struct btrfs_fs_info *fs_info); > int btrfs_add_log_tree(struct btrfs_trans_handle *trans, > -- > 2.9.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index eb1ee7b6f532..8c479bd5534a 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -1222,10 +1222,10 @@ int btrfs_write_tree_block(struct extent_buffer *buf) buf->start + buf->len - 1); } -int btrfs_wait_tree_block_writeback(struct extent_buffer *buf) +void btrfs_wait_tree_block_writeback(struct extent_buffer *buf) { - return filemap_fdatawait_range(buf->pages[0]->mapping, - buf->start, buf->start + buf->len - 1); + filemap_fdatawait_range(buf->pages[0]->mapping, + buf->start, buf->start + buf->len - 1); } struct extent_buffer *read_tree_block(struct btrfs_fs_info *fs_info, u64 bytenr, diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h index 2e0ec29bfd69..9cc87835abb5 100644 --- a/fs/btrfs/disk-io.h +++ b/fs/btrfs/disk-io.h @@ -127,7 +127,7 @@ int btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct inode *inode, extent_submit_bio_hook_t *submit_bio_done); unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info); int btrfs_write_tree_block(struct extent_buffer *buf); -int btrfs_wait_tree_block_writeback(struct extent_buffer *buf); +void btrfs_wait_tree_block_writeback(struct extent_buffer *buf); int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans, struct btrfs_fs_info *fs_info); int btrfs_add_log_tree(struct btrfs_trans_handle *trans,
Nothing checks its return value. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/btrfs/disk-io.c | 6 +++--- fs/btrfs/disk-io.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)