From patchwork Mon Jan 29 02:58:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 10188805 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D637860388 for ; Mon, 29 Jan 2018 02:58:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5D691FF40 for ; Mon, 29 Jan 2018 02:58:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A9F0928639; Mon, 29 Jan 2018 02:58:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3BBB11FF40 for ; Mon, 29 Jan 2018 02:58:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbeA2C62 (ORCPT ); Sun, 28 Jan 2018 21:58:28 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:50286 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbeA2C61 (ORCPT ); Sun, 28 Jan 2018 21:58:27 -0500 Received: by mail-it0-f65.google.com with SMTP id x128so6548559ite.0 for ; Sun, 28 Jan 2018 18:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=VhlpVhwhuHRFfZ+ejwEiulWzm4mPii86prAR1KeOMQ4=; b=eEbFnPgiBcOqxIs0b1t0wreCQzYdXqjtFJ2g14yo7h4pfOY4ybhavKRQU6wfsx8gVu dAIfq2jmOC5R06iC95yXFgJ9Y/TfdmDu6cgl6Qj5uJMhgANISRPc+Y3dei7wUWcKYy84 jaYsXuqfiADmaoIl8fJCQdcR8gtiocQvldJlSj2EwLQ4VyzuneAqO6tjF+pqcZbr5jV3 ih4Zg7EdscO5IdZEK43an2sexa6RdHeFdzZN65ZY/CVcy6ojO77FLnXH9HpdB+r3VrfS 71mOtkZ9tTKRX0LUSoOhYLrOy6zDY9Q4PvBmk+M0xrznFFDzePzzo6mzPHNAj3u1YuFF CB/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=VhlpVhwhuHRFfZ+ejwEiulWzm4mPii86prAR1KeOMQ4=; b=AW/W+jzaYfmQj+6Nt6DV7FLFXKLt0wsTdq7Hk4ezfj3T6saUf840dnhXudBig0i6om Wv4pWapTB0paguqNHrbrfhQ59hP8kcL0jqsAgfhlKUBoKZwGAcBb/A1wp93oDTw0G1ST plbHMm1hNg1KKzuOGVf9hfgznOjTh3mjT5wJyskb5f64eWa6W172xAobKO5yjL7DWE0V B0mhtteazznXno/S0/oxHtdbaldqIdUS3gEvvvaN0ljATN93Ir06ZNrGVzl6cw9rYWqw Rs1K8uBR4Q2BdROlSHaVaegTYym1lC7kpCTiBWiDhirlIpjnn7KItdDE0Ns4jpJA1w5n kFUw== X-Gm-Message-State: AKwxytd3X8f8BTkaZ183ZmbBpIytVz1zgXE1rvRd7dJGlKB2mQI1oduK nJ23hV8y0n0EY7T3a4bMRS1nRio= X-Google-Smtp-Source: AH8x2267RQkWFJJ4cl04QnsujW4Uy9oPSvG9TtANjEdJDQEhGGY3BuNJbZq8aZvsRqjUfV/D8YCcyg== X-Received: by 10.36.120.136 with SMTP id p130mr12533698itc.115.1517194706399; Sun, 28 Jan 2018 18:58:26 -0800 (PST) Received: from localhost.localdomain (50-36-85-67.alma.mi.frontiernet.net. [50.36.85.67]) by smtp.gmail.com with ESMTPSA id w125sm5265667itb.31.2018.01.28.18.58.25 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jan 2018 18:58:25 -0800 (PST) From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH 1/2] NFS: Remove a redundant call to unmap_mapping_range() Date: Sun, 28 Jan 2018 21:58:21 -0500 Message-Id: <20180129025822.5116-1-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We don't need to call unmap_mapping_range() prior to calling nfs_sync_mapping(). Signed-off-by: Trond Myklebust --- fs/nfs/inode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index deeb7d1097d0..49fba9ea5872 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -1170,7 +1170,6 @@ static int nfs_invalidate_mapping(struct inode *inode, struct address_space *map if (mapping->nrpages != 0) { if (S_ISREG(inode->i_mode)) { - unmap_mapping_range(mapping, 0, 0, 0); ret = nfs_sync_mapping(mapping); if (ret < 0) return ret;