From patchwork Tue Mar 20 20:53:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 10297869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D1DA960386 for ; Tue, 20 Mar 2018 20:54:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C37132867F for ; Tue, 20 Mar 2018 20:54:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B809D287ED; Tue, 20 Mar 2018 20:54:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6819D2867F for ; Tue, 20 Mar 2018 20:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751586AbeCTUyE (ORCPT ); Tue, 20 Mar 2018 16:54:04 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:33137 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbeCTUx6 (ORCPT ); Tue, 20 Mar 2018 16:53:58 -0400 Received: by mail-io0-f194.google.com with SMTP id l3so4057745iog.0 for ; Tue, 20 Mar 2018 13:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LIdVZglikEVujyNlquJ8QS+J+3CPPOO5IZlx1PaSNus=; b=XmC9DrxW53xDh0HDSwHsxUDd4HjX61Mi0Es32m6E+zQgmUzReCUZIIKQpq3rPpj+BC lL6SJG7bnlI9HbMnJxL2e5X3SUcGrtlQ1xCeZJXbAKTQwyXAJ5HXgw5yERcH+D+fUatn YrfVDHhCgaFBS0z/45Q5JH1QobtdBTG3fK7WvYfE0jAob3iSnlKF8TF4tjbuSr4iK1XN +m/ZmoGM3FKA7xXJeV5ys67V+FRJ4tqvL4yaLQxyx9xW+VocMMreKRYr8Lm3XF3G+iXU Z3LacdK87tK99wN0c3SwToTNijEXcqxC3V1rKY5ueUzb+RyJtuRsVPetMeAlomqISwhm tALw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LIdVZglikEVujyNlquJ8QS+J+3CPPOO5IZlx1PaSNus=; b=IR0QuFg8rEAqUF9CW8tejcvBFw76KfzMQ9FvTMozc5fNEWIMVLCBos7Nomk9TxNqq6 ac3s3CYxYKmTSoZKAWht3AlsZTvueEpW7GobaG3SFmYfIaoi1oYoem6oy2UX58WR147u iXcmj/umBqK21IfKqmQKpFgRnSjvH8kiv8sw184snHpA32pi8BIHrqaCLuI3FKMh1jfS 3V48GWvmSttzrhYIqatW4j1gdZu2y0r1Tk2aET03mJg24JtsaZD28J3gmIz/O6SDjtqo sVhkflWlKcprERBG+/Qglk5G4406KL8SE6FgVKID734sDZ7pvA8gHoY4adGX9aqaqT76 LTeQ== X-Gm-Message-State: AElRT7FUQVbj/ro7EAaU4hZvNWRvEIjocDVdUUo7ZUnR5ehk4mtcMf9c aOcjqy4AgaPGI0/fFgvj/JxuIEk= X-Google-Smtp-Source: AG47ELte+1O9rjBIRcXmWzXX1zRNiWgegohXbRxdePg1K+0aYW/kIw3bocUAumFp9AzxEN8owDqN2A== X-Received: by 10.107.84.8 with SMTP id i8mr16511407iob.254.1521579237464; Tue, 20 Mar 2018 13:53:57 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id r13sm1619364ioa.1.2018.03.20.13.53.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Mar 2018 13:53:56 -0700 (PDT) From: Trond Myklebust To: Anna Schumaker Cc: linux-nfs@vger.kernel.org Subject: [PATCH 2/6] NFS: Don't force a revalidation of all attributes if change is missing Date: Tue, 20 Mar 2018 16:53:28 -0400 Message-Id: <20180320205332.94132-3-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180320205332.94132-2-trond.myklebust@primarydata.com> References: <20180320205332.94132-1-trond.myklebust@primarydata.com> <20180320205332.94132-2-trond.myklebust@primarydata.com> MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if the change attribute is missing, it is still OK to mark the other attributes as being up to date. Signed-off-by: Trond Myklebust --- fs/nfs/inode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 9da00b2e26a1..5a721c3f4eb0 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -1813,7 +1813,10 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr) inode_set_iversion_raw(inode, fattr->change_attr); } } else { - nfsi->cache_validity |= save_cache_validity; + nfsi->cache_validity |= save_cache_validity & + (NFS_INO_INVALID_ATTR + | NFS_INO_REVAL_PAGECACHE + | NFS_INO_REVAL_FORCED); cache_revalidated = false; }