diff mbox

fs: nfs: Adding new return type vm_fault_t

Message ID 20180414194442.GA20044@jordon-HP-15-Notebook-PC (mailing list archive)
State New, archived
Headers show

Commit Message

Souptick Joarder April 14, 2018, 7:44 p.m. UTC
Use new return type vm_fault_t for page_mkwrite
handler.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
---
 fs/nfs/file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Souptick Joarder May 11, 2018, 6:30 p.m. UTC | #1
On Sun, Apr 15, 2018 at 1:14 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Use new return type vm_fault_t for page_mkwrite
> handler.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
>  fs/nfs/file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/file.c b/fs/nfs/file.c
> index 81cca49..29553fd 100644
> --- a/fs/nfs/file.c
> +++ b/fs/nfs/file.c
> @@ -532,13 +532,13 @@ static void nfs_swap_deactivate(struct file *file)
>   * writable, implying that someone is about to modify the page through a
>   * shared-writable mapping
>   */
> -static int nfs_vm_page_mkwrite(struct vm_fault *vmf)
> +static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf)
>  {
>         struct page *page = vmf->page;
>         struct file *filp = vmf->vma->vm_file;
>         struct inode *inode = file_inode(filp);
>         unsigned pagelen;
> -       int ret = VM_FAULT_NOPAGE;
> +       vm_fault_t ret = VM_FAULT_NOPAGE;
>         struct address_space *mapping;
>
>         dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n",
> --
> 1.9.1
>

Any comment for this patch ? We would like to get this patch
queued for 4.18.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Souptick Joarder May 23, 2018, 11:54 a.m. UTC | #2
On Sat, May 12, 2018 at 12:00 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> On Sun, Apr 15, 2018 at 1:14 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> Use new return type vm_fault_t for page_mkwrite
>> handler.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
>> ---
>>  fs/nfs/file.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfs/file.c b/fs/nfs/file.c
>> index 81cca49..29553fd 100644
>> --- a/fs/nfs/file.c
>> +++ b/fs/nfs/file.c
>> @@ -532,13 +532,13 @@ static void nfs_swap_deactivate(struct file *file)
>>   * writable, implying that someone is about to modify the page through a
>>   * shared-writable mapping
>>   */
>> -static int nfs_vm_page_mkwrite(struct vm_fault *vmf)
>> +static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf)
>>  {
>>         struct page *page = vmf->page;
>>         struct file *filp = vmf->vma->vm_file;
>>         struct inode *inode = file_inode(filp);
>>         unsigned pagelen;
>> -       int ret = VM_FAULT_NOPAGE;
>> +       vm_fault_t ret = VM_FAULT_NOPAGE;
>>         struct address_space *mapping;
>>
>>         dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n",
>> --
>> 1.9.1
>>
>
> Any comment for this patch ? We would like to get this patch
> queued for 4.18.

If no comment, We would like to get this patch in queue for 4.18.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 81cca49..29553fd 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -532,13 +532,13 @@  static void nfs_swap_deactivate(struct file *file)
  * writable, implying that someone is about to modify the page through a
  * shared-writable mapping
  */
-static int nfs_vm_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t nfs_vm_page_mkwrite(struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;
 	struct file *filp = vmf->vma->vm_file;
 	struct inode *inode = file_inode(filp);
 	unsigned pagelen;
-	int ret = VM_FAULT_NOPAGE;
+	vm_fault_t ret = VM_FAULT_NOPAGE;
 	struct address_space *mapping;

 	dfprintk(PAGECACHE, "NFS: vm_page_mkwrite(%pD2(%lu), offset %lld)\n",