From patchwork Mon Sep 3 15:29:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 10586105 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9169E17DE for ; Mon, 3 Sep 2018 15:30:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82275294FC for ; Mon, 3 Sep 2018 15:30:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7683D2962F; Mon, 3 Sep 2018 15:30:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CC972963A for ; Mon, 3 Sep 2018 15:30:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727434AbeICTvE (ORCPT ); Mon, 3 Sep 2018 15:51:04 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:34485 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727458AbeICTvE (ORCPT ); Mon, 3 Sep 2018 15:51:04 -0400 Received: by mail-io0-f193.google.com with SMTP id c22-v6so707482iob.1 for ; Mon, 03 Sep 2018 08:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=97pcY3A/yBo+IeZ4luwKj0BgmnfzHt2rnhJH40lGVNs=; b=Gjt6Qn00ZnivX2Qxta2xfkLHq7sUqjqt5+QIDy1Pj5i/X41JjDuWzDMTRXzRq6hTwk sQyGuo6AKVjHN+HP6B0FlCX6Gl1ednNUzdZ/2f0qz/PFozDzBCvH9+wPWvb121WPxJMZ 1hbE4u4WjnxmfIhvv5e56llOk9WkQGVrKaps3dsfNEMPSujwOzbrDxdeyBiTs57MLVbY vgVUhbZhbpypsGaaIBeiG61elNYzAENgMsmGdkHZna5nCqcwAtTosLEZaErMXUlGBF63 oFQYRoxCNGF58Q4m2oPWwJfl+VrSuCSim0C3LoEfeWA60MZME/KZLURrQ/2hUXZ7RaMs StBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=97pcY3A/yBo+IeZ4luwKj0BgmnfzHt2rnhJH40lGVNs=; b=BfI6Sru/bfPWhm4fKchTJPCurhtof2ezWEoxtMve2vy+Wetl8TN1Gm/wD6duIYmcNY aX6QieKdurxXlVWaIh6s37kJ/40Gup6osJIe/mpAtlC+XsIEP4yNWrSq5IUSo8moNOOi QP7i3CD8bVz0AL4wsF/s0t0c5CkDEpTTO11ehTySO9gllJ4E+PZCkfHQeW5bWRajQB/P J8EWfedogj3pDs53v7Zzb2xJM4x/Gcgazg0ncbvAX6CcxXRUxQ7ZdMlF0+ulyNNhQDcw J6ZGbsMeoaxcfMOxzwMjBjTpIFVfNMNcnlsqpg/MEuwHoE6ZcyP7CutzyK7WjsmhxJKP nB8A== X-Gm-Message-State: APzg51AqSCAYLHZJok3tEAjYqvYgCk2urcwN/ucoc4kVYmHPuAPJyGkP 1f5QGdYMOUZvnW+vebOFUXF8n0Q= X-Google-Smtp-Source: ANB0VdYrzliiQ2ccyeReEJsY8WiYndW3Trz+zNO5pDozx0uONadSMxb4qTSKVkHtJCK7ylk3G5H4Eg== X-Received: by 2002:a6b:a0d2:: with SMTP id j201-v6mr18532799ioe.41.1535988623798; Mon, 03 Sep 2018 08:30:23 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-40-195-73.hsd1.mi.comcast.net. [68.40.195.73]) by smtp.gmail.com with ESMTPSA id c25-v6sm7040027iob.30.2018.09.03.08.30.23 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 08:30:23 -0700 (PDT) From: Trond Myklebust X-Google-Original-From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH 26/27] SUNRPC: Queue the request for transmission immediately after encoding Date: Mon, 3 Sep 2018 11:29:35 -0400 Message-Id: <20180903152936.24325-27-trond.myklebust@hammerspace.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903152936.24325-26-trond.myklebust@hammerspace.com> References: <20180903152936.24325-1-trond.myklebust@hammerspace.com> <20180903152936.24325-2-trond.myklebust@hammerspace.com> <20180903152936.24325-3-trond.myklebust@hammerspace.com> <20180903152936.24325-4-trond.myklebust@hammerspace.com> <20180903152936.24325-5-trond.myklebust@hammerspace.com> <20180903152936.24325-6-trond.myklebust@hammerspace.com> <20180903152936.24325-7-trond.myklebust@hammerspace.com> <20180903152936.24325-8-trond.myklebust@hammerspace.com> <20180903152936.24325-9-trond.myklebust@hammerspace.com> <20180903152936.24325-10-trond.myklebust@hammerspace.com> <20180903152936.24325-11-trond.myklebust@hammerspace.com> <20180903152936.24325-12-trond.myklebust@hammerspace.com> <20180903152936.24325-13-trond.myklebust@hammerspace.com> <20180903152936.24325-14-trond.myklebust@hammerspace.com> <20180903152936.24325-15-trond.myklebust@hammerspace.com> <20180903152936.24325-16-trond.myklebust@hammerspace.com> <20180903152936.24325-17-trond.myklebust@hammerspace.com> <20180903152936.24325-18-trond.myklebust@hammerspace.com> <20180903152936.24325-19-trond.myklebust@hammerspace.com> <20180903152936.24325-20-trond.myklebust@hammerspace.com> <20180903152936.24325-21-trond.myklebust@hammerspace.com> <20180903152936.24325-22-trond.myklebust@hammerspace.com> <20180903152936.24325-23-trond.myklebust@hammerspace.com> <20180903152936.24325-24-trond.myklebust@hammerspace.com> <20180903152936.24325-25-trond.myklebust@hammerspace.com> <20180903152936.24325-26-trond.myklebust@hammerspace.com> MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move up the call to xprt_request_enqueue_transmit() to call_encode() so that the queue order reflects the order in which slots were allocated. Signed-off-by: Trond Myklebust --- net/sunrpc/clnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 586976c4c02a..8eea3c4d2532 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -1785,6 +1785,7 @@ call_encode(struct rpc_task *task) if (rpc_reply_expected(task)) xprt_request_enqueue_receive(task); set_bit(RPC_TASK_NEED_XMIT, &task->tk_runstate); + xprt_request_enqueue_transmit(task); out: task->tk_action = call_bind; } @@ -1971,7 +1972,6 @@ call_transmit(struct rpc_task *task) dprint_status(task); task->tk_action = call_transmit_status; - xprt_request_enqueue_transmit(task); if (!test_bit(RPC_TASK_NEED_XMIT, &task->tk_runstate)) return;