From patchwork Tue Sep 4 21:05:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 10587947 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A26A0180E for ; Tue, 4 Sep 2018 21:06:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 923A629FC2 for ; Tue, 4 Sep 2018 21:06:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 866022A0B9; Tue, 4 Sep 2018 21:06:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3447829FC2 for ; Tue, 4 Sep 2018 21:06:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbeIEBdY (ORCPT ); Tue, 4 Sep 2018 21:33:24 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:50337 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726749AbeIEBdY (ORCPT ); Tue, 4 Sep 2018 21:33:24 -0400 Received: by mail-it0-f66.google.com with SMTP id j81-v6so7043024ite.0 for ; Tue, 04 Sep 2018 14:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=g9YXx1e6e0OdM/iPh1NgYASNzGGFREd51RVoGg8+IP0=; b=UMGAC6NjWSV2opWuh062legFcV1WST0LBhVaB2mLFAUpCAZWJSuunSi+6iqmpc2H8R yLFKkIdK1mms983HC+3r9TZq+rdcnu4lHVdECuq2aEAsYCDdCT1p2yhAqCFkpSDK/uA0 G9kz3bB3eVV5/mpLrBv1V+30l6odP3jncGGlwjPYwBZzb3shq3j6/zx2C4Rqk9tG8Ogq ipL6413ZuW3c8wiZYU+XWCcSUrXy6t2ZB6GG1qnt9tQu5vgLN1deLFj8cUPhs4mJs8uT aLJW+2ezEn070+o93kBSPwyBSgdFUMVq26CR9WOZzl8t5wS/3BUCEadeVMUp+LcmiV1R mBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g9YXx1e6e0OdM/iPh1NgYASNzGGFREd51RVoGg8+IP0=; b=NpXBYHjM/Ki4EaYG4RntzcJYwI0EJb1o6HMYTreJPG6z7xu0RC+xuiMpyvjqH/5FsK 24DAuyItqmooHNaW+FusXzVNsa9Au19Yd1GyRvihO97GV6x1PnGusganmaey5f4MMfxJ tnV8YN3Cwjhh3BCfqB7XyL1IkBnBMsyEwR2Y6XPQwHkyYy2n/AlwKs47K7D+BWOQzK9L p0EShye4LF5H7TJhUX/1sk1cAXkmnIokyqAFyFdgDKJO6brGTF+wv2hGUltJdwn1vceH KY+8sI37/jwj6zgGvVPdqllr6DIG02fnj1JzX1M5thi7+ZO2IleI9NYtzRW51kaJotaF UeNQ== X-Gm-Message-State: APzg51CfAVgil+9KyUVSfOZ+w45FveKRctGAKEOXisYSXm6M+r8XDkWu 2YZfu7JxgoyRMcJFtH0lFqW35iw= X-Google-Smtp-Source: ANB0VdaUMU97bSH1vcXyOXUmewrZahjQSbe8PRRFz/0DK3icmc0x0uI5W+14XMeMXzvTdhjdnMW86Q== X-Received: by 2002:a02:158a:: with SMTP id 10-v6mr23207425jaq.18.1536095191915; Tue, 04 Sep 2018 14:06:31 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-40-195-73.hsd1.mi.comcast.net. [68.40.195.73]) by smtp.gmail.com with ESMTPSA id t64-v6sm172860ita.13.2018.09.04.14.06.31 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Sep 2018 14:06:31 -0700 (PDT) From: Trond Myklebust X-Google-Original-From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH v2 28/34] SUNRPC: Queue the request for transmission immediately after encoding Date: Tue, 4 Sep 2018 17:05:43 -0400 Message-Id: <20180904210549.81673-29-trond.myklebust@hammerspace.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180904210549.81673-28-trond.myklebust@hammerspace.com> References: <20180904210549.81673-1-trond.myklebust@hammerspace.com> <20180904210549.81673-2-trond.myklebust@hammerspace.com> <20180904210549.81673-3-trond.myklebust@hammerspace.com> <20180904210549.81673-4-trond.myklebust@hammerspace.com> <20180904210549.81673-5-trond.myklebust@hammerspace.com> <20180904210549.81673-6-trond.myklebust@hammerspace.com> <20180904210549.81673-7-trond.myklebust@hammerspace.com> <20180904210549.81673-8-trond.myklebust@hammerspace.com> <20180904210549.81673-9-trond.myklebust@hammerspace.com> <20180904210549.81673-10-trond.myklebust@hammerspace.com> <20180904210549.81673-11-trond.myklebust@hammerspace.com> <20180904210549.81673-12-trond.myklebust@hammerspace.com> <20180904210549.81673-13-trond.myklebust@hammerspace.com> <20180904210549.81673-14-trond.myklebust@hammerspace.com> <20180904210549.81673-15-trond.myklebust@hammerspace.com> <20180904210549.81673-16-trond.myklebust@hammerspace.com> <20180904210549.81673-17-trond.myklebust@hammerspace.com> <20180904210549.81673-18-trond.myklebust@hammerspace.com> <20180904210549.81673-19-trond.myklebust@hammerspace.com> <20180904210549.81673-20-trond.myklebust@hammerspace.com> <20180904210549.81673-21-trond.myklebust@hammerspace.com> <20180904210549.81673-22-trond.myklebust@hammerspace.com> <20180904210549.81673-23-trond.myklebust@hammerspace.com> <20180904210549.81673-24-trond.myklebust@hammerspace.com> <20180904210549.81673-25-trond.myklebust@hammerspace.com> <20180904210549.81673-26-trond.myklebust@hammerspace.com> <20180904210549.81673-27-trond.myklebust@hammerspace.com> <20180904210549.81673-28-trond.myklebust@hammerspace.com> MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move up the call to xprt_request_enqueue_transmit() to call_encode() so that the queue order reflects the order in which slots were allocated. Signed-off-by: Trond Myklebust --- net/sunrpc/clnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 52494baca7bc..4f8803413499 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -1785,6 +1785,7 @@ call_encode(struct rpc_task *task) if (rpc_reply_expected(task)) xprt_request_enqueue_receive(task); set_bit(RPC_TASK_NEED_XMIT, &task->tk_runstate); + xprt_request_enqueue_transmit(task); out: task->tk_action = call_bind; } @@ -1971,7 +1972,6 @@ call_transmit(struct rpc_task *task) dprint_status(task); task->tk_action = call_transmit_status; - xprt_request_enqueue_transmit(task); if (!test_bit(RPC_TASK_NEED_XMIT, &task->tk_runstate)) return;