[19/19] Removed a resource leak from nfsdcltrack/sqlite.c

Message ID	20190508133536.6077-20-steved@redhat.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-nfs-owner@kernel.org> From: Steve Dickson <steved@redhat.com> To: Linux NFS Mailing list <linux-nfs@vger.kernel.org> Subject: [PATCH 19/19] Removed a resource leak from nfsdcltrack/sqlite.c Date: Wed, 8 May 2019 09:35:36 -0400 Message-Id: <20190508133536.6077-20-steved@redhat.com> In-Reply-To: <20190508133536.6077-1-steved@redhat.com> References: <20190508133536.6077-1-steved@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk
Series	Covertity Scan: Removed resources leaks \| expand [00/19] Covertity Scan: Removed resources leaks [01/19] Removed resource leaks from junction/path.c [02/19] Removed resource leaks from nfs/exports.c [03/19] Removed a resource leak from nfs/mydaemon.c [04/19] Removed a resource leak from nfs/rpcmisc.c [05/19] Removed a resource leak from nfs/svc_socket.c [06/19] Removed bad frees from nfs/xcommon.c [07/19] Removed resource leaks from nfs/xlog.c [08/19] Removed resource leaks from nfsidmap/libnfsidmap.c [09/19] Removed resource leaks from nfsidmap/static.c [10/19] Removed a resource leak from nsm/file.c [11/19] Removed resource leaks from systemd/rpc-pipefs-generator.c [12/19] Removed resource leaks from blkmapd/device-discovery.c [13/19] Removed resource leaks from gssd/krb5_util.c [14/19] Removed a resource leak from mount/configfile.c [15/19] Removed a resource leak from mount/nfsmount.c [16/19] Removed a resource leak from mount/stropts.c [17/19] Removed resource leaks from mountd/cache.c [18/19] Removed a resource leak from mountd/fsloc.c [19/19] Removed a resource leak from nfsdcltrack/sqlite.c

Message ID

20190508133536.6077-20-steved@redhat.com (mailing list archive)

State

New, archived

Headers

From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 19/19] Removed a resource leak from nfsdcltrack/sqlite.c
Date: Wed,  8 May 2019 09:35:36 -0400
Message-Id: <20190508133536.6077-20-steved@redhat.com>
In-Reply-To: <20190508133536.6077-1-steved@redhat.com>
References: <20190508133536.6077-1-steved@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Series

Covertity Scan: Removed resources leaks | expand

Commit Message

Steve Dickson May 8, 2019, 1:35 p.m. UTC

nfsdcltrack/sqlite.c:218: leaked_storage: Variable "err" going out
	of scope leaks the storage it points to.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 utils/nfsdcltrack/sqlite.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/utils/nfsdcltrack/sqlite.c b/utils/nfsdcltrack/sqlite.c
index c59f777..2801201 100644
--- a/utils/nfsdcltrack/sqlite.c
+++ b/utils/nfsdcltrack/sqlite.c
@@ -215,6 +215,8 @@  sqlite_maindb_init_v2(void)
 				&err);
 	if (ret != SQLITE_OK) {
 		xlog(L_ERROR, "Unable to begin transaction: %s", err);
+		if (err)
+			sqlite3_free(err);
 		return ret;
 	}

[19/19] Removed a resource leak from nfsdcltrack/sqlite.c

Commit Message

Patch