diff mbox series

[1/1] NFSv4.1 make cachethis=no for writes

Message ID 20200212223212.14638-1-olga.kornievskaia@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/1] NFSv4.1 make cachethis=no for writes | expand

Commit Message

Olga Kornievskaia Feb. 12, 2020, 10:32 p.m. UTC 
From: Olga Kornievskaia <kolga@netapp.com>

Turning caching off for writes on the server should improve performance.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 fs/nfs/nfs4proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Trond Myklebust Feb. 13, 2020, 1:20 a.m. UTC | #1 
On Wed, 2020-02-12 at 17:32 -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> Turning caching off for writes on the server should improve
> performance.
> 
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  fs/nfs/nfs4proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 7f5802b..22dca49 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5336,7 +5336,7 @@ static void nfs4_proc_write_setup(struct
> nfs_pgio_header *hdr,
>  	hdr->timestamp   = jiffies;
>  
>  	msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_WRITE];
> -	nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 1,
> 0);
> +	nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 0,
> 0);
>  	nfs4_state_protect_write(server->nfs_client, clnt, msg, hdr);
>  }
>  

Reviewed-by: Trond Myklebust <trond.myklebust@hammerspace.com>


Anna, we can probably also add a

Fixes: fba83f34119a ("NFS: Pass "privileged" value to nfs4_init_sequence()")
diff mbox series

Patch

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 7f5802b..22dca49 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5336,7 +5336,7 @@  static void nfs4_proc_write_setup(struct nfs_pgio_header *hdr,
 	hdr->timestamp   = jiffies;
 
 	msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_WRITE];
-	nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 1, 0);
+	nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 0, 0);
 	nfs4_state_protect_write(server->nfs_client, clnt, msg, hdr);
 }