[v1,13/22] SUNRPC: Remove dprintk call site in call_decode

Message ID	20200708201008.22129.15426.stgit@manet.1015granger.net (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=7+dT=AT=vger.kernel.org=linux-nfs-owner@kernel.org> Subject: [PATCH v1 13/22] SUNRPC: Remove dprintk call site in call_decode From: Chuck Lever <chuck.lever@oracle.com> To: linux-nfs@vger.kernel.org Date: Wed, 08 Jul 2020 16:10:08 -0400 Message-ID: <20200708201008.22129.15426.stgit@manet.1015granger.net> In-Reply-To: <20200708200121.22129.92375.stgit@manet.1015granger.net> References: <20200708200121.22129.92375.stgit@manet.1015granger.net> User-Agent: StGit/0.22-38-gfb18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk
Series	SUNRPC: Replace dprintk calls with tracepoints \| expand [v1,00/22] SUNRPC: Replace dprintk calls with tracepoints [v1,01/22] SUNRPC: Remove trace_xprt_complete_rqst() [v1,02/22] SUNRPC: Hoist trace_xprtrdma_op_allocate into generic code [v1,03/22] SUNRPC: Remove debugging instrumentation from xprt_release [v1,04/22] SUNRPC: Update debugging instrumentation in xprt_do_reserve() [v1,05/22] SUNRPC: Replace dprintk() call site in xprt_prepare_transmit [v1,06/22] SUNRPC: Replace dprintk() call site in xs_nospace() [v1,07/22] SUNRPC: Remove the dprint_status() macro [v1,08/22] SUNRPC: Remove dprintk call site in call_start() [v1,09/22] SUNRPC: Replace connect dprintk call sites with a tracepoint [v1,10/22] SUNRPC: Mitigate cond_resched() in xprt_transmit() [v1,11/22] SUNRPC: Add trace_rpc_timeout_status() [v1,12/22] SUNRPC: Trace call_refresh events [v1,13/22] SUNRPC: Remove dprintk call site in call_decode [v1,14/22] SUNRPC: Clean up call_bind_status() observability [v1,15/22] SUNRPC: Remove rpcb_getport_async dprintk call sites [v1,16/22] SUNRPC: Hoist trace_xprtrdma_op_setport into generic code [v1,17/22] SUNRPC: Remove dprintk call sites in rpcbind XDR functions [v1,18/22] SUNRPC: Remove more dprintks in rpcb_clnt.c [v1,19/22] SUNRPC: Replace rpcbind dprintk call sites with tracepoints [v1,20/22] SUNRPC: Clean up RPC scheduler tracepoints [v1,21/22] SUNRPC: Remove dprintk call sites in RPC queuing functions [v1,22/22] SUNRPC: Remove remaining dprintks from sched.c

Message ID

20200708201008.22129.15426.stgit@manet.1015granger.net (mailing list archive)

State

New, archived

Headers

Subject: [PATCH v1 13/22] SUNRPC: Remove dprintk call site in call_decode
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org
Date: Wed, 08 Jul 2020 16:10:08 -0400
Message-ID: <20200708201008.22129.15426.stgit@manet.1015granger.net>
In-Reply-To: <20200708200121.22129.92375.stgit@manet.1015granger.net>
References: <20200708200121.22129.92375.stgit@manet.1015granger.net>
User-Agent: StGit/0.22-38-gfb18
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Series

SUNRPC: Replace dprintk calls with tracepoints | expand

Commit Message

Chuck Lever July 8, 2020, 8:10 p.m. UTC

Clean up.

When enabled, this dprintk adds a line in /var/log/messages after
every RPC that reports the task ID (no connection to on the wire
XID values) and the RPC's result (no connection to the program,
operation, or the arguments and results).

Thus it's value is pretty low. Let's remove it.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 net/sunrpc/clnt.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 2bdfc4d0d860..90e3d9dae34c 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -2496,8 +2496,6 @@  call_decode(struct rpc_task *task)
 	case 0:
 		task->tk_action = rpc_exit_task;
 		task->tk_status = rpcauth_unwrap_resp(task, &xdr);
-		dprintk("RPC: %5u %s result %d\n",
-			task->tk_pid, __func__, task->tk_status);
 		return;
 	case -EAGAIN:
 		task->tk_status = 0;

[v1,13/22] SUNRPC: Remove dprintk call site in call_decode

Commit Message

Patch