diff mbox series

[v2] nfs: Fix security label length not being reset

Message ID 20200915214252.262881-1-jeffrey.mitchell@starlab.io
State New
Headers show
Series [v2] nfs: Fix security label length not being reset | expand

Commit Message

Jeffrey Mitchell Sept. 15, 2020, 9:42 p.m. UTC
nfs_readdir_page_filler() iterates over entries in a directory, reusing
the same security label buffer, but does not reset the buffer's length.
This causes decode_attr_security_label() to return -ERANGE if an entry's
security label is longer than the previous one's. This error, in
nfs4_decode_dirent(), only gets passed up as -EAGAIN, which causes another
failed attempt to copy into the buffer. The second error is ignored and
the remaining entries do not show up in ls, specifically the getdents64()

Reproduce by creating multiple files in NFS and giving one of the later
files a longer security label. ls will not see that file nor any that are
added afterwards, though they will exist on the backend.

In nfs_readdir_page_filler(), reset security label buffer length before
every reuse

Signed-off-by: Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
v2: Added explanation from cover letter as requested by J. Bruce Fields

 fs/nfs/dir.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series


diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index e732580fe47b..cb52db9a0cfb 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -579,6 +579,9 @@  int nfs_readdir_page_filler(nfs_readdir_descriptor_t *desc, struct nfs_entry *en
 	xdr_set_scratch_buffer(&stream, page_address(scratch), PAGE_SIZE);
 	do {
+		if (entry->label)
+			entry->label->len = NFS4_MAXLABELLEN;
 		status = xdr_decode(desc, entry, &stream);
 		if (status != 0) {
 			if (status == -EAGAIN)