diff mbox series

nfs: use 'break' instead of 'fallthrough'

Message ID 20200924105802.31987-1-sudipm.mukherjee@gmail.com
State New
Headers show
Series nfs: use 'break' instead of 'fallthrough' | expand

Commit Message

Sudip Mukherjee Sept. 24, 2020, 10:58 a.m. UTC
The fallthrough attribute should only be used in a switch statement,
after a preceding statement and before a logically succeeding case
label, or user-defined label.

But here, it is used in the last 'switch-case' with no other 'case' where
it can fallthrough. So, use break instead of fallthrough.

Fixes: cf65e49f89f2 ("nfs: Convert to use the preferred fallthrough macro")
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
 fs/nfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index d20326ee0475..eb2401079b04 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -889,7 +889,7 @@  static struct nfs_server *nfs_try_mount_request(struct fs_context *fc)
 			if (rpcauth_get_gssinfo(flavor, &info) != 0)
-			fallthrough;
+			break;
 		dfprintk(MOUNT, "NFS: attempting to use auth flavor %u\n", flavor);
 		ctx->selected_flavor = flavor;