diff mbox series

[2/2] NFSD: fix missing refcount in nfsd4_copy by nfsd4_do_async_copy

Message ID 20201029190716.70481-3-dai.ngo@oracle.com
State New
Headers show
Series NFSD: Fix use-after-free warning when doing inter-server copy | expand

Commit Message

Dai Ngo Oct. 29, 2020, 7:07 p.m. UTC
Need to initialize nfsd4_copy's refcount to 1 to avoid use-after-free
warning when nfs4_put_copy is called from nfsd4_cb_offload_release.

Fixes: ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
 fs/nfsd/nfs4proc.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 9c43cad7e408..e83b21778816 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1486,6 +1486,7 @@  static int nfsd4_do_async_copy(void *data)
 	cb_copy = kzalloc(sizeof(struct nfsd4_copy), GFP_KERNEL);
 	if (!cb_copy)
 		goto out;
+	refcount_set(&cb_copy->refcount, 1);
 	memcpy(&cb_copy->cp_res, &copy->cp_res, sizeof(copy->cp_res));
 	cb_copy->cp_clp = copy->cp_clp;
 	cb_copy->nfserr = copy->nfserr;