From patchwork Sat Nov 7 14:03:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 11888977 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5C9DA6A2 for ; Sat, 7 Nov 2020 14:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4361A20888 for ; Sat, 7 Nov 2020 14:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604758419; bh=MOBmL2uL4txSencAZUUeyuOlu/ZATH07W1xk5scpDbw=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=OVy53a21giGvNXRinE/0UWt9Fi8sajY9Y5//gKKPzQsXsN5kI/9+o/O8HDu22G1dQ /GQ1eJLb6DJQOnbAeegbYvLtLIJ37myMHdr6Mu/2tgyU2vv/boJyzXA1nhSfIYBb7K 0LLGE3JKnTB60q0cwWJGrDFJF2pSPAWXIwaUjKwA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727298AbgKGONi (ORCPT ); Sat, 7 Nov 2020 09:13:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:58210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbgKGONh (ORCPT ); Sat, 7 Nov 2020 09:13:37 -0500 Received: from localhost.localdomain (c-68-36-133-222.hsd1.mi.comcast.net [68.36.133.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC47F207C3 for ; Sat, 7 Nov 2020 14:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604758417; bh=MOBmL2uL4txSencAZUUeyuOlu/ZATH07W1xk5scpDbw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=M4Rwr4zUpIH4t7C9MFAeluB1yDt3eiMKwToiWqfoRx74X8XimgsM7Jtz2DzwyGOjl v5/dn9FuVR7t6LcX6gDtnkDAkarSGdnlG7dyq7Rm2XTMgLOxrFhUQT+G4Xt1+cEPMs 369gnc7sAyV6y18zChXmSwdy+oGvxe0y+vCimhzI= From: trondmy@kernel.org To: linux-nfs@vger.kernel.org Subject: [PATCH v4 02/21] NFS: Remove unnecessary inode lock in nfs_fsync_dir() Date: Sat, 7 Nov 2020 09:03:06 -0500 Message-Id: <20201107140325.281678-3-trondmy@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201107140325.281678-2-trondmy@kernel.org> References: <20201107140325.281678-1-trondmy@kernel.org> <20201107140325.281678-2-trondmy@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust nfs_inc_stats() is already thread-safe, and there are no other reasons to hold the inode lock here. Signed-off-by: Trond Myklebust --- fs/nfs/dir.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index e56b1bd99537..4e011adaf967 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -997,13 +997,9 @@ static loff_t nfs_llseek_dir(struct file *filp, loff_t offset, int whence) static int nfs_fsync_dir(struct file *filp, loff_t start, loff_t end, int datasync) { - struct inode *inode = file_inode(filp); - dfprintk(FILE, "NFS: fsync dir(%pD2) datasync %d\n", filp, datasync); - inode_lock(inode); - nfs_inc_stats(inode, NFSIOS_VFSFSYNC); - inode_unlock(inode); + nfs_inc_stats(file_inode(filp), NFSIOS_VFSFSYNC); return 0; }