diff mbox series

nfsd: Fix message level for normal termination

Message ID 20201127024439.32297-1-kzpn200@gmail.com (mailing list archive)
State New
Headers show
Series nfsd: Fix message level for normal termination | expand

Commit Message

kazuo ito Nov. 27, 2020, 2:44 a.m. UTC
A warning message from nfsd terminating normally
can confuse system adminstrators or monitoring software.

Though it's not exactly fair to pin-point a commit where it
originated, the current form in the current place started
to appear in:

Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
Signed-off-by: kazuo ito <kzpn200@gmail.com>
---
 fs/nfsd/nfssvc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chuck Lever Nov. 27, 2020, 3:56 a.m. UTC | #1
> On Nov 26, 2020, at 9:46 PM, kazuo ito <kzpn200@gmail.com> wrote:
> 
> A warning message from nfsd terminating normally
> can confuse system adminstrators or monitoring software.
> 
> Though it's not exactly fair to pin-point a commit where it
> originated, the current form in the current place started
> to appear in:
> 
> Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
> Signed-off-by: kazuo ito <kzpn200@gmail.com>
> ---
> fs/nfsd/nfssvc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index f7f6473578af..b08cccb71787 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -527,8 +527,8 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
>        return;
> 
>    nfsd_shutdown_net(net);
> -    printk(KERN_WARNING "nfsd: last server has exited, flushing export "
> -                "cache\n");
> +    printk(KERN_INFO "nfsd: last server has exited, flushing export "
> +             "cache\n");

pr_info(), please! And see if it will fit on one line.


>    nfsd_export_flush(net);
> }
> 
> -- 
> 2.20.1
>
diff mbox series

Patch

diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index f7f6473578af..b08cccb71787 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -527,8 +527,8 @@  static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
 		return;
 
 	nfsd_shutdown_net(net);
-	printk(KERN_WARNING "nfsd: last server has exited, flushing export "
-			    "cache\n");
+	printk(KERN_INFO "nfsd: last server has exited, flushing export "
+			 "cache\n");
 	nfsd_export_flush(net);
 }