diff mbox series

nfsd: Fix message level for normal termination

Message ID 20201127062659.605229-1-kzpn200@gmail.com (mailing list archive)
State New
Headers show
Series nfsd: Fix message level for normal termination | expand

Commit Message

kazuo ito Nov. 27, 2020, 6:26 a.m. UTC
The warning message from nfsd terminating normally
can confuse system adminstrators or monitoring software.

Though it's not exactly fair to pin-point a commit where it
originated, the current form in the current place started
to appear in:

Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
Signed-off-by: kazuo ito <kzpn200@gmail.com>
---
 fs/nfsd/nfssvc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Chuck Lever Nov. 27, 2020, 5:11 p.m. UTC | #1
> On Nov 27, 2020, at 1:26 AM, kazuo ito <kzpn200@gmail.com> wrote:
> 
> The warning message from nfsd terminating normally
> can confuse system adminstrators or monitoring software.
> 
> Though it's not exactly fair to pin-point a commit where it
> originated, the current form in the current place started
> to appear in:
> 
> Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
> Signed-off-by: kazuo ito <kzpn200@gmail.com>
> ---
> fs/nfsd/nfssvc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 27b1ad136150..9323e30a7eaf 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -527,8 +527,7 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
> 		return;
> 
> 	nfsd_shutdown_net(net);
> -	printk(KERN_WARNING "nfsd: last server has exited, flushing export "
> -			    "cache\n");
> +	pr_info("nfsd: last server has exited, flushing export cache\n");
> 	nfsd_export_flush(net);
> }

Thanks.

Applied internally for the next full merge window. It should
appear soon in the cel-next topic branch at:

  git://git.linux-nfs.org/projects/cel/cel-2.6.git

or

  https://git.linux-nfs.org/?p=cel/cel-2.6.git;a=summary

--
Chuck Lever
diff mbox series

Patch

diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 27b1ad136150..9323e30a7eaf 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -527,8 +527,7 @@  static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
 		return;
 
 	nfsd_shutdown_net(net);
-	printk(KERN_WARNING "nfsd: last server has exited, flushing export "
-			    "cache\n");
+	pr_info("nfsd: last server has exited, flushing export cache\n");
 	nfsd_export_flush(net);
 }