diff mbox series

exportfs: Ingnore export failures in nfs-server.serivce unit

Message ID 20201210182452.20898-1-steved@redhat.com (mailing list archive)
State New
Headers show
Series exportfs: Ingnore export failures in nfs-server.serivce unit | expand

Commit Message

Steve Dickson Dec. 10, 2020, 6:24 p.m. UTC
With some recent commits, exportfs will continue on trying to
export filesystems even when an entry is invalid or does
not exist, but will still have a non-zero exit to report
the error.

This situation should not stop the nfs-server service
from comingup so nfs-server.service file should
ignore these types of failures

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 systemd/nfs-server.service | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Steve Dickson Dec. 11, 2020, 1:48 p.m. UTC | #1
On 12/10/20 1:24 PM, Steve Dickson wrote:
> With some recent commits, exportfs will continue on trying to
> export filesystems even when an entry is invalid or does
> not exist, but will still have a non-zero exit to report
> the error.
> 
> This situation should not stop the nfs-server service
> from comingup so nfs-server.service file should
> ignore these types of failures
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed. (tag: nfs-utils-2-5-3-rc2)

steved.
> ---
>  systemd/nfs-server.service | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index 06c1adb..b432f91 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -21,13 +21,13 @@ After=rpc-gssd.service gssproxy.service rpc-svcgssd.service
>  [Service]
>  Type=oneshot
>  RemainAfterExit=yes
> -ExecStartPre=/usr/sbin/exportfs -r
> +ExecStartPre=-/usr/sbin/exportfs -r
>  ExecStart=/usr/sbin/rpc.nfsd
>  ExecStop=/usr/sbin/rpc.nfsd 0
>  ExecStopPost=/usr/sbin/exportfs -au
>  ExecStopPost=/usr/sbin/exportfs -f
>  
> -ExecReload=/usr/sbin/exportfs -r
> +ExecReload=-/usr/sbin/exportfs -r
>  
>  [Install]
>  WantedBy=multi-user.target
>
diff mbox series

Patch

diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
index 06c1adb..b432f91 100644
--- a/systemd/nfs-server.service
+++ b/systemd/nfs-server.service
@@ -21,13 +21,13 @@  After=rpc-gssd.service gssproxy.service rpc-svcgssd.service
 [Service]
 Type=oneshot
 RemainAfterExit=yes
-ExecStartPre=/usr/sbin/exportfs -r
+ExecStartPre=-/usr/sbin/exportfs -r
 ExecStart=/usr/sbin/rpc.nfsd
 ExecStop=/usr/sbin/rpc.nfsd 0
 ExecStopPost=/usr/sbin/exportfs -au
 ExecStopPost=/usr/sbin/exportfs -f
 
-ExecReload=/usr/sbin/exportfs -r
+ExecReload=-/usr/sbin/exportfs -r
 
 [Install]
 WantedBy=multi-user.target