| Message ID | 20210312170604.56169-1-pmenzel@molgen.mpg.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] nfsd: Log error on UMH upcall init failure and debug message on success | expand |
diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index 891395c6c7d3..db66c45a6b97 100644 --- a/fs/nfsd/nfs4recover.c +++ b/fs/nfsd/nfs4recover.c @@ -1864,7 +1864,7 @@ nfsd4_umh_cltrack_init(struct net *net) ret = nfsd4_umh_cltrack_upcall("init", NULL, grace_start, NULL); kfree(grace_start); if (!ret) - printk("NFSD: Using UMH upcall client tracking operations.\n"); + pr_info("NFSD: Using UMH upcall client tracking operations.\n"); return ret; }
By default, using `printk()`, Linux logs messages with level warning, which leaves the user reading NFSD: Using UMH upcall client tracking operations. wondering what to do about it. Reading `nfsd4_umh_cltrack_init()`, the message is actually logged on success, so nothing needs to be done, and it was decided to use the debug level. Additionally, Linux now logs an error on init failure. NFSD: Failed to init UMH upcall client tracking operations. Cc: linux-nfs@vger.kernel.org Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> --- fs/nfsd/nfs4recover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)