| Message ID | 20210617090458.1491-1-thunder.leizhen@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] nfsd: remove unnecessary oom message | expand |
On Thu, Jun 17, 2021 at 05:04:57PM +0800, Zhen Lei wrote: > Fixes scripts/checkpatch.pl warning: > WARNING: Possible unnecessary 'out of memory' message > > Remove it can help us save a bit of memory. On a quick check, I think the other 6 pr_err()s in here also (pretty unlikely) allocation failures, may as well remove those too? --b. > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > fs/nfsd/filecache.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c > index 7629248fdd53..76d68b2b4ba2 100644 > --- a/fs/nfsd/filecache.c > +++ b/fs/nfsd/filecache.c > @@ -643,10 +643,8 @@ nfsd_file_cache_init(void) > > nfsd_file_hashtbl = kcalloc(NFSD_FILE_HASH_SIZE, > sizeof(*nfsd_file_hashtbl), GFP_KERNEL); > - if (!nfsd_file_hashtbl) { > - pr_err("nfsd: unable to allocate nfsd_file_hashtbl\n"); > + if (!nfsd_file_hashtbl) > goto out_err; > - } > > nfsd_file_slab = kmem_cache_create("nfsd_file", > sizeof(struct nfsd_file), 0, 0, NULL); > -- > 2.25.1 >
diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index 7629248fdd53..76d68b2b4ba2 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -643,10 +643,8 @@ nfsd_file_cache_init(void) nfsd_file_hashtbl = kcalloc(NFSD_FILE_HASH_SIZE, sizeof(*nfsd_file_hashtbl), GFP_KERNEL); - if (!nfsd_file_hashtbl) { - pr_err("nfsd: unable to allocate nfsd_file_hashtbl\n"); + if (!nfsd_file_hashtbl) goto out_err; - } nfsd_file_slab = kmem_cache_create("nfsd_file", sizeof(struct nfsd_file), 0, 0, NULL);
Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- fs/nfsd/filecache.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)