| Message ID | 20211019041422.975072-1-deng.changcheng@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | NFSD:fix boolreturn.cocci warning | expand |
> On Oct 19, 2021, at 12:14 AM, cgel.zte@gmail.com wrote: > > From: Changcheng Deng <deng.changcheng@zte.com.cn> > > ./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function > 'nfssvc_decode_voidarg' with return type bool > > Return statements in functions returning bool should use true/false > instead of 1/0. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> LGTM. > --- > fs/nfsd/nfssvc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c > index 362e819ff06a..80431921e5d7 100644 > --- a/fs/nfsd/nfssvc.c > +++ b/fs/nfsd/nfssvc.c > @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp) > */ > bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr) > { > - return 1; > + return true; > } > > /** > -- > 2.25.1 > -- Chuck Lever
On Tue, Oct 19, 2021 at 02:33:36PM +0000, Chuck Lever III wrote: > > > > On Oct 19, 2021, at 12:14 AM, cgel.zte@gmail.com wrote: > > > > From: Changcheng Deng <deng.changcheng@zte.com.cn> > > > > ./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function > > 'nfssvc_decode_voidarg' with return type bool > > > > Return statements in functions returning bool should use true/false > > instead of 1/0. > > > > Reported-by: Zeal Robot <zealci@zte.com.cn> > > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> > > LGTM. OK, applying for 5.16.--b. > > > > --- > > fs/nfsd/nfssvc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c > > index 362e819ff06a..80431921e5d7 100644 > > --- a/fs/nfsd/nfssvc.c > > +++ b/fs/nfsd/nfssvc.c > > @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp) > > */ > > bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr) > > { > > - return 1; > > + return true; > > } > > > > /** > > -- > > 2.25.1 > > > > -- > Chuck Lever > >
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index 362e819ff06a..80431921e5d7 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp) */ bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr) { - return 1; + return true; } /**