From patchwork Tue Nov 30 11:34:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 12646861 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A8BC433EF for ; Tue, 30 Nov 2021 11:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240784AbhK3LZE (ORCPT ); Tue, 30 Nov 2021 06:25:04 -0500 Received: from szxga08-in.huawei.com ([45.249.212.255]:28132 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238808AbhK3LY6 (ORCPT ); Tue, 30 Nov 2021 06:24:58 -0500 Received: from dggeml709-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4J3KVB0W5Qz1DJh0; Tue, 30 Nov 2021 19:18:58 +0800 (CST) Received: from localhost.localdomain (10.175.102.38) by dggeml709-chm.china.huawei.com (10.3.17.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Tue, 30 Nov 2021 19:21:37 +0800 From: Wei Yongjun To: , NeilBrown , "J. Bruce Fields" , Chuck Lever CC: , , Hulk Robot Subject: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static Date: Tue, 30 Nov 2021 11:34:36 +0000 Message-ID: <20211130113436.1770168-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.102.38] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggeml709-chm.china.huawei.com (10.3.17.139) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org The sparse tool complains as follows: fs/nfsd/nfssvc.c:437:1: warning: symbol 'nfsd_notifier_lock' was not declared. Should it be static? This symbol is not used outside of nfssvc.c, so marks it static. Fixes: 6ac25fbcbde9 ("NFSD: simplify locking for network notifier.") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- fs/nfsd/nfssvc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index 070525fbc1ad..14c1ef6f8cc7 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -434,7 +434,7 @@ static void nfsd_shutdown_net(struct net *net) nfsd_shutdown_generic(); } -DEFINE_SPINLOCK(nfsd_notifier_lock); +static DEFINE_SPINLOCK(nfsd_notifier_lock); static int nfsd_inetaddr_event(struct notifier_block *this, unsigned long event, void *ptr) {