diff mbox series

NFSv4.1: RECLAIM_COMPLETE must handle EACCES

Message ID 20220727100107.3062-1-wang.yi59@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series NFSv4.1: RECLAIM_COMPLETE must handle EACCES | expand

Commit Message

Yi Wang July 27, 2022, 10:01 a.m. UTC 
From: Zhang Xianwei <zhang.xianwei8@zte.com.cn>

A client should be able to handle getting an EACCES error while doing
a mount operation to reclaim state due to NFS4CLNT_RECLAIM_REBOOT
being set. If the server returns RPC_AUTH_BADCRED because authentication
failed when we execute "exportfs -au", then RECLAIM_COMPLETE will go a
wrong way. After mount succeeds, all OPEN call will fail due to an
NFS4ERR_GRACE error being returned. This patch is to fix it by resending
a RPC request.

Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
 fs/nfs/nfs4proc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Yi Wang Aug. 9, 2022, 3:10 a.m. UTC | #1 
Gentle ping :)

> From: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
>
> A client should be able to handle getting an EACCES error while doing
> a mount operation to reclaim state due to NFS4CLNT_RECLAIM_REBOOT
> being set. If the server returns RPC_AUTH_BADCRED because authentication
> failed when we execute "exportfs -au", then RECLAIM_COMPLETE will go a
> wrong way. After mount succeeds, all OPEN call will fail due to an
> NFS4ERR_GRACE error being returned. This patch is to fix it by resending
> a RPC request.
>
> Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> ---
> fs/nfs/nfs4proc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index bb0e84a46d61..b51b83506011 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -9477,6 +9477,9 @@ static int nfs41_reclaim_complete_handle_errors(struct rpc_task *task, struct nf
> rpc_delay(task, NFS4_POLL_RETRY_MAX);
> fallthrough;
> case -NFS4ERR_RETRY_UNCACHED_REP:
> + case -EACCES:
> + dprintk("%s: failed to reclaim complete error %d for server %s, retrying\n",
> + __func__, task->tk_status, clp->cl_hostname);
> return -EAGAIN;
> case -NFS4ERR_BADSESSION:
> case -NFS4ERR_DEADSESSION:
diff mbox series

Patch

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index bb0e84a46d61..b51b83506011 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -9477,6 +9477,9 @@  static int nfs41_reclaim_complete_handle_errors(struct rpc_task *task, struct nf
 		rpc_delay(task, NFS4_POLL_RETRY_MAX);
 		fallthrough;
 	case -NFS4ERR_RETRY_UNCACHED_REP:
+	case -EACCES:
+		dprintk("%s: failed to reclaim complete error %d for server %s, retrying\n",
+			__func__, task->tk_status, clp->cl_hostname);
 		return -EAGAIN;
 	case -NFS4ERR_BADSESSION:
 	case -NFS4ERR_DEADSESSION: