diff mbox series

[nfs/nfs-utils/libtirpc] bindresvport.c: fix a potential resource leakage

Message ID 20221020063309.3674419-1-yieli@redhat.com (mailing list archive)
State New, archived
Headers show
Series [nfs/nfs-utils/libtirpc] bindresvport.c: fix a potential resource leakage | expand

Commit Message

Zhi Li Oct. 20, 2022, 6:33 a.m. UTC
Close the FILE *fp of load_blacklist() in another
return path to avoid potential resource leakage.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2135405
Signed-off-by: Zhi Li <yieli@redhat.com>
---
 src/bindresvport.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Steve Dickson Oct. 24, 2022, 5:48 p.m. UTC | #1
On 10/20/22 2:33 AM, Zhi Li wrote:
> Subject:
> [PATCH] [nfs/nfs-utils/libtirpc] bindresvport.c: fix a potential 
> resource leakage
> From:
> Zhi Li <yieli@redhat.com>
> Date:
> 10/20/22, 2:33 AM
> 
> To:
> linux-nfs@vger.kernel.org
> CC:
> steved@redhat.com, Zhi Li <yieli@redhat.com>
> 
> 
> Close the FILE *fp of load_blacklist() in another
> return path to avoid potential resource leakage.
> 
> Fixes:https://bugzilla.redhat.com/show_bug.cgi?id=2135405
> Signed-off-by: Zhi Li<yieli@redhat.com>
Committed...

steved.
> ---
>   src/bindresvport.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/bindresvport.c b/src/bindresvport.c
> index 5c0ddcf..efeb1cc 100644
> --- a/src/bindresvport.c
> +++ b/src/bindresvport.c
> @@ -130,6 +130,7 @@ load_blacklist (void)
>   	  if (list == NULL)
>   	    {
>   	      free (buf);
> +	      fclose (fp);
>   	      return;
>   	    }
>   	}
> -- 2.31.1
>
diff mbox series

Patch

diff --git a/src/bindresvport.c b/src/bindresvport.c
index 5c0ddcf..efeb1cc 100644
--- a/src/bindresvport.c
+++ b/src/bindresvport.c
@@ -130,6 +130,7 @@  load_blacklist (void)
 	  if (list == NULL)
 	    {
 	      free (buf);
+	      fclose (fp);
 	      return;
 	    }
 	}