| Message ID | 20221122132815.15673-1-dolinux.peng@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | NFS: dprintk() should not print negative inode number | expand |
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 6b2cfa59a1a2..53d8704e07c5 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -2081,7 +2081,7 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr) if (S_ISDIR(inode->i_mode)) nfs_force_lookup_revalidate(inode); attr_changed = true; - dprintk("NFS: change_attr change on server for file %s/%ld\n", + dprintk("NFS: change_attr change on server for file %s/%lu\n", inode->i_sb->s_id, inode->i_ino); } else if (!have_delegation)
The type of the i_ino member of the inode structure is unsigned long. There are some occurrences where dprintk() outputs a negative inode number.This leads to confusion and more difficult to read debugging. Fixes: 9e6e70f8d8b6 ("NFSv4: Support NFSv4 optional attributes in the struct nfs_fattr") Signed-off-by: Donglin Peng <dolinux.peng@gmail.com> --- fs/nfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)