| Message ID | 20230722033116.17988-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] sunrpc: Remove unused extern declarations | expand |
On Fri, Jul 21, 2023 at 11:31:16PM -0400, YueHaibing wrote: > Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") > these declarations are unused, so can remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> LGTM, applied to nfsd-next. Thank you! > --- > include/linux/sunrpc/svcauth.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h > index 6d9cc9080aca..2402b7ca5d1a 100644 > --- a/include/linux/sunrpc/svcauth.h > +++ b/include/linux/sunrpc/svcauth.h > @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); > > extern struct auth_domain *unix_domain_find(char *name); > extern void auth_domain_put(struct auth_domain *item); > -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); > extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); > extern struct auth_domain *auth_domain_find(char *name); > extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); > -extern int auth_unix_forget_old(struct auth_domain *dom); > extern void svcauth_unix_purge(struct net *net); > extern void svcauth_unix_info_release(struct svc_xprt *xpt); > extern int svcauth_unix_set_client(struct svc_rqst *rqstp); > -- > 2.34.1 >
On Sat, 22 Jul 2023, YueHaibing wrote: > Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") > these declarations are unused, so can remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks. Could you remove the declaration of auth_unix_lookup too? It was removed in that commit, but the declaration is still with us. Thanks! NeilBrown > --- > include/linux/sunrpc/svcauth.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h > index 6d9cc9080aca..2402b7ca5d1a 100644 > --- a/include/linux/sunrpc/svcauth.h > +++ b/include/linux/sunrpc/svcauth.h > @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); > > extern struct auth_domain *unix_domain_find(char *name); > extern void auth_domain_put(struct auth_domain *item); > -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); > extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); > extern struct auth_domain *auth_domain_find(char *name); > extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); > -extern int auth_unix_forget_old(struct auth_domain *dom); > extern void svcauth_unix_purge(struct net *net); > extern void svcauth_unix_info_release(struct svc_xprt *xpt); > extern int svcauth_unix_set_client(struct svc_rqst *rqstp); > -- > 2.34.1 > >
On 2023/7/24 13:08, NeilBrown wrote: > On Sat, 22 Jul 2023, YueHaibing wrote: >> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") >> these declarations are unused, so can remove it. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thanks. > Could you remove the declaration of auth_unix_lookup too? > It was removed in that commit, but the declaration is still with us. Sure, will do this. > > Thanks! > NeilBrown > >> --- >> include/linux/sunrpc/svcauth.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h >> index 6d9cc9080aca..2402b7ca5d1a 100644 >> --- a/include/linux/sunrpc/svcauth.h >> +++ b/include/linux/sunrpc/svcauth.h >> @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); >> >> extern struct auth_domain *unix_domain_find(char *name); >> extern void auth_domain_put(struct auth_domain *item); >> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); >> extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); >> extern struct auth_domain *auth_domain_find(char *name); >> extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); >> -extern int auth_unix_forget_old(struct auth_domain *dom); >> extern void svcauth_unix_purge(struct net *net); >> extern void svcauth_unix_info_release(struct svc_xprt *xpt); >> extern int svcauth_unix_set_client(struct svc_rqst *rqstp); >> -- >> 2.34.1 >> >> > > . >
On Mon, Jul 24, 2023 at 02:45:07PM +0800, YueHaibing wrote: > On 2023/7/24 13:08, NeilBrown wrote: > > On Sat, 22 Jul 2023, YueHaibing wrote: > >> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") > >> these declarations are unused, so can remove it. > >> > >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > > > Thanks. > > Could you remove the declaration of auth_unix_lookup too? > > It was removed in that commit, but the declaration is still with us. Thanks, Neil. I thought there might be one or two others, but none stood out to me. > Sure, will do this. Yue, I can just fold that into the applied patch. No need to send another. > > Thanks! > > NeilBrown > > > >> --- > >> include/linux/sunrpc/svcauth.h | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h > >> index 6d9cc9080aca..2402b7ca5d1a 100644 > >> --- a/include/linux/sunrpc/svcauth.h > >> +++ b/include/linux/sunrpc/svcauth.h > >> @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); > >> > >> extern struct auth_domain *unix_domain_find(char *name); > >> extern void auth_domain_put(struct auth_domain *item); > >> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); > >> extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); > >> extern struct auth_domain *auth_domain_find(char *name); > >> extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); > >> -extern int auth_unix_forget_old(struct auth_domain *dom); > >> extern void svcauth_unix_purge(struct net *net); > >> extern void svcauth_unix_info_release(struct svc_xprt *xpt); > >> extern int svcauth_unix_set_client(struct svc_rqst *rqstp); > >> -- > >> 2.34.1 > >> > >> > > > > . > >
On 2023/7/24 21:25, Chuck Lever wrote: > On Mon, Jul 24, 2023 at 02:45:07PM +0800, YueHaibing wrote: >> On 2023/7/24 13:08, NeilBrown wrote: >>> On Sat, 22 Jul 2023, YueHaibing wrote: >>>> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") >>>> these declarations are unused, so can remove it. >>>> >>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >>> >>> Thanks. >>> Could you remove the declaration of auth_unix_lookup too? >>> It was removed in that commit, but the declaration is still with us. > > Thanks, Neil. I thought there might be one or two others, but none stood > out to me. > > >> Sure, will do this. > > Yue, I can just fold that into the applied patch. No need to send another. Ok. > > >>> Thanks! >>> NeilBrown >>> >>>> --- >>>> include/linux/sunrpc/svcauth.h | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h >>>> index 6d9cc9080aca..2402b7ca5d1a 100644 >>>> --- a/include/linux/sunrpc/svcauth.h >>>> +++ b/include/linux/sunrpc/svcauth.h >>>> @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); >>>> >>>> extern struct auth_domain *unix_domain_find(char *name); >>>> extern void auth_domain_put(struct auth_domain *item); >>>> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); >>>> extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); >>>> extern struct auth_domain *auth_domain_find(char *name); >>>> extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); >>>> -extern int auth_unix_forget_old(struct auth_domain *dom); >>>> extern void svcauth_unix_purge(struct net *net); >>>> extern void svcauth_unix_info_release(struct svc_xprt *xpt); >>>> extern int svcauth_unix_set_client(struct svc_rqst *rqstp); >>>> -- >>>> 2.34.1 >>>> >>>> >>> >>> . >>> >
diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h index 6d9cc9080aca..2402b7ca5d1a 100644 --- a/include/linux/sunrpc/svcauth.h +++ b/include/linux/sunrpc/svcauth.h @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); extern struct auth_domain *unix_domain_find(char *name); extern void auth_domain_put(struct auth_domain *item); -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); extern struct auth_domain *auth_domain_find(char *name); extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); -extern int auth_unix_forget_old(struct auth_domain *dom); extern void svcauth_unix_purge(struct net *net); extern void svcauth_unix_info_release(struct svc_xprt *xpt); extern int svcauth_unix_set_client(struct svc_rqst *rqstp);
Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") these declarations are unused, so can remove it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- include/linux/sunrpc/svcauth.h | 2 -- 1 file changed, 2 deletions(-)