| Message ID | 20231205223543.31443-1-pvorel@suse.cz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] reexport/{fsidd,reexport}.c: Re-add missing includes | expand |
Hi Petr, On 05/12/23 23:35, Petr Vorel wrote: > Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2), > <sys/un.h> for struct sockaddr_un. > > Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers") > Fixes: bdc79f02 ("support/reexport.c: Remove unused headers") > Signed-off-by: Petr Vorel <pvorel@suse.cz> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Best regards
On 06/12/23 19:53, Giulio Benetti wrote: > Hi Petr, > > On 05/12/23 23:35, Petr Vorel wrote: >> Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2), >> <sys/un.h> for struct sockaddr_un. >> >> Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers") >> Fixes: bdc79f02 ("support/reexport.c: Remove unused headers") >> Signed-off-by: Petr Vorel <pvorel@suse.cz> > > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Build tested along with patch "[PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h>" Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Best regards
On 12/5/23 5:35 PM, Petr Vorel wrote: > Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2), > <sys/un.h> for struct sockaddr_un. > > Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers") > Fixes: bdc79f02 ("support/reexport.c: Remove unused headers") > Signed-off-by: Petr Vorel <pvorel@suse.cz> Committed... (tag: nfs-utils-2-7-1-rc3 steved. > --- > Changes v1->v2: > * Add also <sys/un.h> > > support/reexport/fsidd.c | 2 ++ > support/reexport/reexport.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c > index 8a70b78f..51750ea3 100644 > --- a/support/reexport/fsidd.c > +++ b/support/reexport/fsidd.c > @@ -7,6 +7,8 @@ > #include <dlfcn.h> > #endif > #include <event2/event.h> > +#include <sys/un.h> > +#include <unistd.h> > > #include "conffile.h" > #include "reexport_backend.h" > diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c > index 0fb49a46..c7bff6a3 100644 > --- a/support/reexport/reexport.c > +++ b/support/reexport/reexport.c > @@ -7,6 +7,7 @@ > #endif > #include <sys/types.h> > #include <sys/vfs.h> > +#include <unistd.h> > #include <errno.h> > > #include "nfsd_path.h"
diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c index 8a70b78f..51750ea3 100644 --- a/support/reexport/fsidd.c +++ b/support/reexport/fsidd.c @@ -7,6 +7,8 @@ #include <dlfcn.h> #endif #include <event2/event.h> +#include <sys/un.h> +#include <unistd.h> #include "conffile.h" #include "reexport_backend.h" diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c index 0fb49a46..c7bff6a3 100644 --- a/support/reexport/reexport.c +++ b/support/reexport/reexport.c @@ -7,6 +7,7 @@ #endif #include <sys/types.h> #include <sys/vfs.h> +#include <unistd.h> #include <errno.h> #include "nfsd_path.h"
Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2), <sys/un.h> for struct sockaddr_un. Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers") Fixes: bdc79f02 ("support/reexport.c: Remove unused headers") Signed-off-by: Petr Vorel <pvorel@suse.cz> --- Changes v1->v2: * Add also <sys/un.h> support/reexport/fsidd.c | 2 ++ support/reexport/reexport.c | 1 + 2 files changed, 3 insertions(+)