diff mbox series

[12/13] cifs_get_link(): bail out in unsafe case

Message ID 20240204021739.1157830-12-viro@zeniv.linux.org.uk (mailing list archive)
State New
Headers show
Series [01/13] fs/super.c: don't drop ->s_user_ns until we free struct super_block itself | expand

Commit Message

Al Viro Feb. 4, 2024, 2:17 a.m. UTC
->d_revalidate() bails out there, anyway.  It's not enough
to prevent getting into ->get_link() in RCU mode, but that
could happen only in a very contrieved setup.  Not worth
trying to do anything fancy here unless ->d_revalidate()
stops kicking out of RCU mode at least in some cases.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
 fs/smb/client/cifsfs.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series


diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
index e902de4e475a..630e74628dfe 100644
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
@@ -1172,6 +1172,9 @@  const char *cifs_get_link(struct dentry *dentry, struct inode *inode,
 	char *target_path;
+	if (!dentry)
+		return ERR_PTR(-ECHILD);
 	target_path = kmalloc(PATH_MAX, GFP_KERNEL);
 	if (!target_path)
 		return ERR_PTR(-ENOMEM);