From patchwork Sun Jun 30 16:37:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Snitzer X-Patchwork-Id: 13717220 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 171AA15696E for ; Sun, 30 Jun 2024 16:38:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719765486; cv=none; b=qFXi6Lp95y67BUe3KLYW84xGaMwykB21GKFYEgR3Tn6hyRaVWioJexo4z4wV0j2BUtQhfcTLYJXtNX75SOxrPUHbzF5MaEGvwItNfnZQdyJzZqEDjA6WA4vyDQ1w3JiuwPfXBZTrx2EliHf+1DVqw+1OYbO+ce8Z2KU7gI3B3C8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719765486; c=relaxed/simple; bh=qE34YemZGEe9NkSzdbrQmELxaCXOmZqaZhtvaeoYnMA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kCTwupk1r0zrcQKkRoTLywBhVVlSeiywUE4tt46DbMc0vDNxjIunapOcoZdJ4+z7yeoNUunghILyxWHFsJilEtiTWvdedgcoC+dJnVhoCYuXnAAnmAWXx3AnfNuMeS0LmnHrGjfc1M6F7UN8TsXftUQq2lD4BF3F14beUU/Cz6M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZCot81Bd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZCot81Bd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B905AC2BD10; Sun, 30 Jun 2024 16:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719765485; bh=qE34YemZGEe9NkSzdbrQmELxaCXOmZqaZhtvaeoYnMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZCot81Bd0R11kPb2i9DTY3ybFmK5osI3JNpggTsCl1GXPauMJVAI0l8mf2Mroo39X ZcdET8MfGxgJqE95+3ixcD+EgTkxOzldV558G9BlYfRMxzhjrhFmrg+hQOuwDQA4+A 9xY5bM93/RAikkau73LPCoLQVkHeMywFIa8N9nx81C0Y4ot2U+J5qaVvaL+T9PBpdf KmRo6e0GZC3rxDVxc1TvedU9E9LQEU0lFortAHtGuXEClgmEGvEuOGNLMLBu1rTkfM zdKXXicnE/XdRg9BrVSZSh+o56goosg+O2JGggOJCpQcNLAso5W1Zc5hPLvSyESXzY QswpXNKmOh48w== From: Mike Snitzer To: linux-nfs@vger.kernel.org Cc: Jeff Layton , Chuck Lever , Anna Schumaker , Trond Myklebust , NeilBrown , snitzer@hammerspace.com Subject: [PATCH v10 17/19] SUNRPC: remove call_allocate() BUG_ON if p_arglen=0 to allow RPC with void arg Date: Sun, 30 Jun 2024 12:37:39 -0400 Message-ID: <20240630163741.48753-18-snitzer@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240630163741.48753-1-snitzer@kernel.org> References: <20240630163741.48753-1-snitzer@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This is needed for the LOCALIO protocol's GETUUID RPC which takes a void arg. The LOCALIO protocol spec in rpcgen syntax is: /* raw RFC 9562 UUID */ typedef u8 uuid_t; program NFS_LOCALIO_PROGRAM { version LOCALIO_V1 { void NULL(void) = 0; uuid_t GETUUID(void) = 1; } = 1; } = 400122; Signed-off-by: Mike Snitzer --- net/sunrpc/clnt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index cfd1b1bf7e35..2d7f96103f08 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -1894,7 +1894,6 @@ call_allocate(struct rpc_task *task) return; if (proc->p_proc != 0) { - BUG_ON(proc->p_arglen == 0); if (proc->p_decode != NULL) BUG_ON(proc->p_replen == 0); }