nfs-utils.spec patch

Commit Message

Henrique Martins Aug. 3, 2014, 2:34 p.m. UTC

The spec file for nfs-utils-1.3.0-2.1.fc20 (nfs-utils.spec)
has a bunch of bad date entries in %changelog which cause
warnings when running rpmbuild.

Patch attached, by changing the weekday to match the day
number.

-- Henrique

Comments

Steve Dickson Aug. 13, 2014, 1:59 p.m. UTC | #1

On 08/03/2014 10:34 AM, Henrique Martins wrote:
> 
> The spec file for nfs-utils-1.3.0-2.1.fc20 (nfs-utils.spec)
> has a bunch of bad date entries in %changelog which cause
> warnings when running rpmbuild.
> 
> Patch attached, by changing the weekday to match the day
> number.

Thanks for doing this!!! I definitely appreciated it!! 

I just did the commit on all three branches (f20,f21,master)
but I didn't rebuild anything... If you need something 
rebuilt, just let me know... 

thanks again! 

steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Henrique Martins Aug. 13, 2014, 3:08 p.m. UTC | #2

me> Patch attached, by changing the weekday to match the day
me> number.

steve> Thanks for doing this!!! I definitely appreciated it!!

You're welcome.

steve> I just did the commit on all three branches
steve> (f20,f21,master) but I didn't rebuild anything... If
steve> you need something rebuilt, just let me know...

No rebuild is needed, but maybe there should be some debate
whether to ignore exportfs errors when starting nfs as the
default, which just requires adding a couple of '-' to the
systemd service file.

A more complicated approach (would require code changes as
opposed to configuration changes) would be to not error out
if there is at least one exported mount point.

-- Henrique
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Steve Dickson Aug. 14, 2014, 9:19 a.m. UTC | #3

On 08/13/2014 11:08 AM, Henrique Martins wrote:
> No rebuild is needed, but maybe there should be some debate
> whether to ignore exportfs errors when starting nfs as the
> default, which just requires adding a couple of '-' to the
> systemd service file.
What would be the reasoning? If there is nothing exported
why come up cleanly?

> 
> A more complicated approach (would require code changes as
> opposed to configuration changes) would be to not error out
> if there is at least one exported mount point.
More complexity than needed... IMHO... 

steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Henrique Martins Aug. 14, 2014, 2:13 p.m. UTC | #4

>> but maybe there should be some debate whether to ignore
>> exportfs errors when starting nfs as the default, which
>> just requires adding a couple of '-' to the systemd
>> service file.

> What would be the reasoning? If there is nothing exported
> why come up cleanly?

The "reasoning" is why I filed:
  https://bugzilla.redhat.com/show_bug.cgi?id=1115179
and explained "it" in comment #2
  https://bugzilla.redhat.com/show_bug.cgi?id=1115179#c2

I have a few machines in a laptop's /etc/exports, some only
resolve when I'm connected to the net at work, some only
resolve when I'm connected to the net at home.  With the
default service file nfs always fails to start...

>> A more complicated approach (would require code changes as
>> opposed to configuration changes) would be to not error out
>> if there is at least one exported mount point.

> More complexity than needed... IMHO...

... and thus the need for the complexity to make it clean,
i.e. as long as there is a machine on the particular net I'm
connected to, that can nfs mount the laptop, nfs server
should start and not require me to do some manual editing of
/etc/exports, or write a script to take care of that.

-- Henrique
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

*** SPECS/nfs-utils.spec.orig	2014-06-03 10:54:25.000000000 -0700
--- SPECS/nfs-utils.spec	2014-08-02 14:16:02.297833025 -0700
***************
*** 671,677 ****
  - Updated to the latest pseudo root release (rel10) which
    containts the upstream pseudo root release

! * Mon Jan 12 2010 Steve Dickson <[e-mail]> 1.2.1-9
  - Updated to latest upstream RC release: nfs-utils-1-2-2-rc5

  * Mon Jan  4 2010 Steve Dickson <[e-mail]> 1.2.1-8
--- 671,677 ----
  - Updated to the latest pseudo root release (rel10) which
    containts the upstream pseudo root release

! * Tue Jan 12 2010 Steve Dickson <[e-mail]> 1.2.1-9
  - Updated to latest upstream RC release: nfs-utils-1-2-2-rc5

  * Mon Jan  4 2010 Steve Dickson <[e-mail]> 1.2.1-8
***************
*** 1062,1068 ****
  - Added -o nordirplus mount option to disable READDIRPLUS (bz 240357)
  - Disabled the FSCache patch, for now...

! * Wed May 10 2007 Steve Dickson <[e-mail]> 1.0.12-5
  - Fix mount.nfs4 to display correct error message (bz 227212)
  - Updated mountd and showmount reverse lookup flags (bz 220772)
  - Eliminate timeout on nfsd shutdowns (bz 222001)
--- 1062,1068 ----
  - Added -o nordirplus mount option to disable READDIRPLUS (bz 240357)
  - Disabled the FSCache patch, for now...

! * Thu May 10 2007 Steve Dickson <[e-mail]> 1.0.12-5
  - Fix mount.nfs4 to display correct error message (bz 227212)
  - Updated mountd and showmount reverse lookup flags (bz 220772)
  - Eliminate timeout on nfsd shutdowns (bz 222001)
***************
*** 1105,1111 ****
  * Wed Dec 13 2006 Steve Dickson <[e-mail]> 1.0.10-5
  - Stopped v4 umounts from ping rpc.mountd (bz 215553)

! * Wed Nov 28 2006 Steve Dickson <[e-mail]> 1.0.10-4
  - Doing a connect on UDP sockets causes the linux network
    stack to reject UDP patches from multi-home server with
    nic on the same subnet. (bz 212471)
--- 1105,1111 ----
  * Wed Dec 13 2006 Steve Dickson <[e-mail]> 1.0.10-5
  - Stopped v4 umounts from ping rpc.mountd (bz 215553)

! * Tue Nov 28 2006 Steve Dickson <[e-mail]> 1.0.10-4
  - Doing a connect on UDP sockets causes the linux network
    stack to reject UDP patches from multi-home server with
    nic on the same subnet. (bz 212471)
***************
*** 1236,1242 ****
  - Updated libevent from 1.0b to 1.1a
  - Added libgssapi-0.4 and librpcsecgss-0.6 libs from CITI

! * Tue Sep  8 2005 Steve Dickson <[e-mail]> 1.0.7-16
  - Reworked the nfslock init script so if lockd is running
    it will be killed which is what the HA community needs. (bz 162446)
  - Stopped rpcidmapd.init from doing extra echoing when
--- 1236,1242 ----
  - Updated libevent from 1.0b to 1.1a
  - Added libgssapi-0.4 and librpcsecgss-0.6 libs from CITI

! * Thu Sep  8 2005 Steve Dickson <[e-mail]> 1.0.7-16
  - Reworked the nfslock init script so if lockd is running
    it will be killed which is what the HA community needs. (bz 162446)
  - Stopped rpcidmapd.init from doing extra echoing when
***************
*** 1267,1273 ****
  * Wed Apr 13 2005 Steve Dickson <[e-mail]> 1.0.7-6
  - Fixed misformated output from nfslock script (bz 154648)

! * Mon Mar 29 2005 Steve Dickson <[e-mail]> 1.0.7-4
  - Fixed a compile error on x86_64 machines in the gss code.
  - Updated the statd-notify-hostname.patch to eliminate
    a segmentation fault in rpc.statd when an network
--- 1267,1273 ----
  * Wed Apr 13 2005 Steve Dickson <[e-mail]> 1.0.7-6
  - Fixed misformated output from nfslock script (bz 154648)

! * Tue Mar 29 2005 Steve Dickson <[e-mail]> 1.0.7-4
  - Fixed a compile error on x86_64 machines in the gss code.
  - Updated the statd-notify-hostname.patch to eliminate
    a segmentation fault in rpc.statd when an network
***************
*** 1362,1368 ****
    by default, there only needs to be away of
    turning them off.

! * Thu May 10 2004 <[e-mail]>
  - Rebuilt

  * Thu Apr 15 2004 <[e-mail]>
--- 1362,1368 ----
    by default, there only needs to be away of
    turning them off.

! * Mon May 10 2004 <[e-mail]>
  - Rebuilt

  * Thu Apr 15 2004 <[e-mail]>
***************
*** 1437,1443 ****
  - Upgrated to 1.0.6
  - Commented out the acl path for fedora

! * Thu Aug  27 2003 Steve Dickson <[e-mail]>
  - Added the setting of lockd ports via sysclt interface
  - Removed queue setting code since its no longer needed

--- 1437,1443 ----
  - Upgrated to 1.0.6
  - Commented out the acl path for fedora

! * Wed Aug  27 2003 Steve Dickson <[e-mail]>
  - Added the setting of lockd ports via sysclt interface
  - Removed queue setting code since its no longer needed

***************
*** 1447,1453 ****
  * Wed Jul 23 2003 Steve Dickson <[e-mail]>
  - Commented out the acl patch (for now)

! * Wed Jul 21 2003 Steve Dickson <[e-mail]>
  - Upgrated to 1.0.5

  * Wed Jun 18 2003 Steve Dickson <[e-mail]>
--- 1447,1453 ----
  * Wed Jul 23 2003 Steve Dickson <[e-mail]>
  - Commented out the acl patch (for now)

! * Mon Jul 21 2003 Steve Dickson <[e-mail]>
  - Upgrated to 1.0.5

  * Wed Jun 18 2003 Steve Dickson <[e-mail]>
***************
*** 1536,1542 ****
  - don't use rquotad from here now; quota package contains a version that
    works with 2.4 (#33738)

! * Tue Mar 12 2001 Bob Matthews <[e-mail]>
  - Statd logs at LOG_DAEMON rather than LOG_LOCAL5
  - s/nfs/\$0/ where appropriate in init scripts

--- 1536,1542 ----
  - don't use rquotad from here now; quota package contains a version that
    works with 2.4 (#33738)

! * Mon Mar 12 2001 Bob Matthews <[e-mail]>
  - Statd logs at LOG_DAEMON rather than LOG_LOCAL5
  - s/nfs/\$0/ where appropriate in init scripts

***************
*** 1562,1568 ****
  - Fix incorrect file specifications in statd manpage.
  - Require gawk 'cause it's used in nfslock init script.

! * Thu Dec 13 2000 Bob Matthews <[e-mail]>
  - Require sed because it's used in nfs init script

  * Tue Dec 12 2000 Bob Matthews <[e-mail]>
--- 1562,1568 ----
  - Fix incorrect file specifications in statd manpage.
  - Require gawk 'cause it's used in nfslock init script.

! * Wed Dec 13 2000 Bob Matthews <[e-mail]>
  - Require sed because it's used in nfs init script

  * Tue Dec 12 2000 Bob Matthews <[e-mail]>