diff mbox

pnfs-obj: No longer needed to take an extra ref at add_device

Message ID 4DFBB84F.2040708@panasas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Boaz Harrosh June 17, 2011, 8:25 p.m. UTC
Andy's last device_cache patches, already take an extra
reference on the newly inserted device_id. So we can remove it
from obj-io.

Without this patch the device_ids are leaked. 

Andy's patches are not in Linus tree yet. So I'm not sure if they are
scheduled for this Kernel or the next. This patch should be added as
part of these.

CC: Andy Adamson <andros@netapp.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
 fs/nfs/objlayout/objio_osd.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff mbox


diff --git a/fs/nfs/objlayout/objio_osd.c b/fs/nfs/objlayout/objio_osd.c
index f014038..70272d5 100644
--- a/fs/nfs/objlayout/objio_osd.c
+++ b/fs/nfs/objlayout/objio_osd.c
@@ -108,7 +108,6 @@  _dev_list_add(const struct nfs_server *nfss,
 		de = n;
-	atomic_inc(&de->id_node.ref);
 	return de;