From patchwork Wed Jun 29 07:21:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: faizan husain X-Patchwork-Id: 927352 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5T7Ls0g008236 for ; Wed, 29 Jun 2011 07:21:54 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751766Ab1F2HVx (ORCPT ); Wed, 29 Jun 2011 03:21:53 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:37676 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830Ab1F2HVw (ORCPT ); Wed, 29 Jun 2011 03:21:52 -0400 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247]) by e23smtp04.au.ibm.com (8.14.4/8.13.1) with ESMTP id p5T7FWAL009462 for ; Wed, 29 Jun 2011 17:15:32 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5T7KNIQ979122 for ; Wed, 29 Jun 2011 17:20:23 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5T7LfJp011832 for ; Wed, 29 Jun 2011 17:21:42 +1000 Received: from [9.79.206.127] ([9.79.206.127]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p5T7LcEJ011793; Wed, 29 Jun 2011 17:21:40 +1000 Message-ID: <4E0AD278.3000503@linux.vnet.ibm.com> Date: Wed, 29 Jun 2011 12:51:28 +0530 From: faizan husain User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: linux-nfs@vger.kernel.org CC: Frank S Filz , jvrao@linux.vnet.ibm.com Subject: [PATCH] nfs4-acl-tools : nfs4_setfacl' failed with unexpected messages if the format of the input file is incorrect. Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 29 Jun 2011 07:21:54 +0000 (UTC) On RHEL5.5 and above releases, read ACL entries to set from file leads to a segmentation fault on pp64, more over the same problem does not show up for x86_64 architecture. here is what i tried. mounted a file system over nfs4. #rpm -qa | grep nfs4 nfs4-acl-tools-0.3.3-5.el6.ppc64 'nfs4_setfacl' failed with unexpected message: #nfs4_setfacl -S file4 file1 *** glibc detected *** nfs4_setfacl: double free or corruption (out): 0x08007760 *** expected out should be like Scanning ACE string 'abcd' failed. Failed while inserting ACE(s). From b8333732964780394518be74ab0b7c61a7e4be4f Mon Sep 17 00:00:00 2001 From: faizan Date: Tue, 28 Jun 2011 16:06:47 +0530 Subject: [PATCH][BUILD]] FIX - 'nfs4_setfacl' failed with unexpected messages iff the format of the input file is incorrect. Signed-off-by: faizan --- libnfs4acl/nfs4_ace_from_string.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- 1.7.1 Regards Faizan -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/libnfs4acl/nfs4_ace_from_string.c b/libnfs4acl/nfs4_ace_from_string.c index 9d877fb..1cc220e 100644 --- a/libnfs4acl/nfs4_ace_from_string.c +++ b/libnfs4acl/nfs4_ace_from_string.c @@ -125,7 +125,6 @@ parse_alloc_fields(char *buf, char *fields[NUMFIELDS]) return 0; out_free: - free_fields(fields); return -ENOMEM; }