From patchwork Fri Jul 1 20:40:07 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 937492 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p61KePM1023257 for ; Fri, 1 Jul 2011 20:40:26 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755761Ab1GAUkU (ORCPT ); Fri, 1 Jul 2011 16:40:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17063 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753516Ab1GAUkR (ORCPT ); Fri, 1 Jul 2011 16:40:17 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p61Ke9IC002446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Jul 2011 16:40:10 -0400 Received: from badhat.bos.devel.redhat.com (vpn-11-138.rdu.redhat.com [10.11.11.138]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p61Ke8hf025957; Fri, 1 Jul 2011 16:40:09 -0400 Message-ID: <4E0E30A7.90209@RedHat.com> Date: Fri, 01 Jul 2011 16:40:07 -0400 From: Steve Dickson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: "Gabor Z. Papp" CC: linux-nfs@vger.kernel.org Subject: Re: nfs-utils 1.2.4 References: In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 01 Jul 2011 20:40:26 +0000 (UTC) On 07/01/2011 02:36 AM, Gabor Z. Papp wrote: > lo lo, > > trying to configure nfs-utils 1.2.4 with the options below: > > --disable-gss --disable-kprefix --enable-mount --enable-nfsv3 > --disable-nfsv4 --with-statduser=nobody --with-statedir=/var/lib/nfs" > --without-tcp-wrappers --disable-tirpc > > but getting the following error: > > [...] > checking size of socklen_t... 4 > configure: error: conditional "CONFIG_NFSIDMAP" was never defined. > Usually this means the macro was only invoked conditionally. The following patch seems to take care of the problem... The problem stemmed from the use of the --disable-nfsv4, which I will throw into my unit tests... Please let me know if this fixes the problem... steved. [PATCH] Make sure CONFIG_NFSIDMAP is always defined. CONFIG_NFSIDMAP always need to be define either negatively or positive whether nfsv4 is or is not defined. Signed-off-by: Steve Dickson --- configure.ac | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/configure.ac b/configure.ac index ca12f9e..f8b0796 100644 --- a/configure.ac +++ b/configure.ac @@ -249,6 +249,9 @@ AC_CHECK_FUNC([getservbyname], , AC_CHECK_LIB([crypt], [crypt], [LIBCRYPT="-lcrypt"]) +dnl enable nfsidmap when its support by libnfsidmap +AM_CONDITIONAL(CONFIG_NFSIDMAP, [test "$enable_nfsidmap" = "yes"]) + if test "$enable_nfsv4" = yes; then dnl check for libevent libraries and headers AC_LIBEVENT @@ -256,9 +259,6 @@ if test "$enable_nfsv4" = yes; then dnl check for nfsidmap libraries and headers AC_LIBNFSIDMAP - dnl enable nfsidmap when its support by libnfsidmap - AM_CONDITIONAL(CONFIG_NFSIDMAP, [test "$enable_nfsidmap" = "yes"]) - dnl check for the keyutils libraries and headers AC_KEYUTILS