From patchwork Thu May 2 15:30:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Radmila_Kompov=C3=A1?= X-Patchwork-Id: 2512551 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 0C6223FCA5 for ; Thu, 2 May 2013 15:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281Ab3EBPlf (ORCPT ); Thu, 2 May 2013 11:41:35 -0400 Received: from eva.fit.vutbr.cz ([147.229.176.14]:29873 "EHLO eva.fit.vutbr.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753427Ab3EBPle (ORCPT ); Thu, 2 May 2013 11:41:34 -0400 X-Greylist: delayed 677 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 May 2013 11:41:34 EDT Received: from [10.0.0.140] (60.195.broadband10.iol.cz [90.177.195.60]) (authenticated bits=0) by eva.fit.vutbr.cz (8.14.5/8.14.5) with ESMTP id r42FUFM6001889 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 2 May 2013 17:30:16 +0200 (CEST) Message-ID: <51828687.7040605@stud.fit.vutbr.cz> Date: Thu, 02 May 2013 17:30:15 +0200 From: =?ISO-8859-1?Q?Radmila_Kompov=E1?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: linux-nfs@vger.kernel.org CC: linux-kernel@vger.kernel.org Subject: [PATCH 2/2] net/sunrpc/auth.c: move NULL check in rpcauth_invalcred() before first dereference X-Scanned-By: MIMEDefang 2.73 on 147.229.176.14 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Detected by cppcheck. Signed-off-by: Kamil Dudka --- net/sunrpc/auth.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c index ed2fdd2..cba5529 100644 --- a/net/sunrpc/auth.c +++ b/net/sunrpc/auth.c @@ -767,11 +767,12 @@ void rpcauth_invalcred(struct rpc_task *task) { struct rpc_cred *cred = task->tk_rqstp->rq_cred; + if (!cred) + return; dprintk("RPC: %5u invalidating %s cred %p\n", task->tk_pid, cred->cr_auth->au_ops->au_name, cred); - if (cred) - clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags); + clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags); } int