From patchwork Thu Oct 9 12:41:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Schumaker, Anna" X-Patchwork-Id: 5058071 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AE3A2C11AB for ; Thu, 9 Oct 2014 12:52:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E135A20122 for ; Thu, 9 Oct 2014 12:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA303201F2 for ; Thu, 9 Oct 2014 12:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbaJIMwW (ORCPT ); Thu, 9 Oct 2014 08:52:22 -0400 Received: from mx1.netapp.com ([216.240.18.38]:33349 "EHLO mx1.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbaJIMwV (ORCPT ); Thu, 9 Oct 2014 08:52:21 -0400 X-Greylist: delayed 621 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 Oct 2014 08:52:21 EDT X-IronPort-AV: E=Sophos;i="5.04,684,1406617200"; d="scan'208";a="347317388" Received: from vmwexchts02-prd.hq.netapp.com ([10.122.105.23]) by mx1-out.netapp.com with ESMTP; 09 Oct 2014 05:41:55 -0700 Received: from smtp2.corp.netapp.com (10.57.159.114) by VMWEXCHTS02-PRD.hq.netapp.com (10.122.105.23) with Microsoft SMTP Server id 15.0.995.29; Thu, 9 Oct 2014 05:41:06 -0700 Received: from davros.ocarinaproject (davros.ocarinaproject.vpn.netapp.com [10.63.227.121]) by smtp2.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id s99Cfrlx006141; Thu, 9 Oct 2014 05:41:54 -0700 (PDT) Message-ID: <54368292.8060209@Netapp.com> Date: Thu, 9 Oct 2014 08:41:54 -0400 From: Anna Schumaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Steve French , "linux-nfs@vger.kernel.org" , linux-fsdevel Subject: Re: xfstests and linux nfs testing References: In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case: Anna On 10/08/14 23:09, Steve French wrote: > Was running into a strange error with xfstests over nfs - must be > missing something obvious since I have run it various times before. > > Tried the following local.config file (placed in root of xfstests directory) > > FSTYP=nfs > TEST_DEV=192.168.93.152:/share-1 > TEST_DIR=/mnt/test > NFS_MOUNT_OPTIONS='-ov3' > > and did > ./check -nfs generic/001 > > which should have worked fine, but it and the various other nfs > capable xfstests returned > > [not run] requires a test device > > which is weird because even setting the TEST_DEV as an environment > variable xfstests still thought it wasn't set. > > Anyone have a sample NFS local.config file for xfstests which works? > --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/common/rc b/common/rc index 34d7c19..e86bbfb 100644 --- a/common/rc +++ b/common/rc @@ -1085,9 +1085,9 @@ _require_scratch() _require_test() { case "$FSTYP" in - nfs*) - _notrun "requires a test device" - ;; + #nfs*) + # _notrun "requires a test device" + # ;; cifs) echo $TEST_DEV | grep -q "//" > /dev/null 2>&1 if [ -z "$TEST_DEV" -o "$?" != "0" ]; then @@ -1097,7 +1097,7 @@ _require_test() _notrun "this test requires a valid \$TEST_DIR" fi ;; - tmpfs) + tmpfs|nfs*) if [ -z "$TEST_DEV" -o ! -d "$TEST_DIR" ]; then _notrun "this test requires a valid \$TEST_DIR and unique $TEST_DEV"