From patchwork Wed Jun 17 07:45:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 6622131 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9DB6D9F326 for ; Wed, 17 Jun 2015 07:45:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C5C5720835 for ; Wed, 17 Jun 2015 07:45:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC6FA20834 for ; Wed, 17 Jun 2015 07:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757878AbbFQHpl (ORCPT ); Wed, 17 Jun 2015 03:45:41 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34403 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757882AbbFQHpk (ORCPT ); Wed, 17 Jun 2015 03:45:40 -0400 Received: by pacgb13 with SMTP id gb13so29338484pac.1; Wed, 17 Jun 2015 00:45:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=IfXFG4GAnUQdL0ojsszuuhKgL3z4F4kbGq9YIM2eN/0=; b=YCoJgbf633+t0GejrK2kKotbt8QKInwy7qrwFkZNwLllzjMH1GqPXryiHGbFQKe1hL LYegHrVXMcM4jBVcznM2YA9RhHT2VhDK4Q89UOHeov2WnWSbXZDjbvVf7pTN+83OeazO 6LSeOyoe1WNnK/xoZsZXvMIvPNb/L48xFWRqtQQdCyTnHk8DYUzmUybVpO8SbnfaaV33 ijpii2hbrzK+iIMF0Gzr+1epFES4chRDWQv9RfGmdMD5uoHPxa7H69CzrHHxI1AlzMZX o9KzgNtWE8/QAIeJsQJVBpqAdE3+JRlM+dNzoC5zbam5TaTfntb/zQPYj59S6hJlqMOQ ViJQ== X-Received: by 10.70.96.139 with SMTP id ds11mr8248900pdb.98.1434527140085; Wed, 17 Jun 2015 00:45:40 -0700 (PDT) Received: from [192.168.99.30] ([104.143.41.79]) by mx.google.com with ESMTPSA id ql9sm3629820pbc.65.2015.06.17.00.45.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2015 00:45:39 -0700 (PDT) Message-ID: <5581259D.7050509@gmail.com> Date: Wed, 17 Jun 2015 15:45:33 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Al Viro , "J. Bruce Fields" , "linux-nfs@vger.kernel.org" , linux-fsdevel@vger.kernel.org CC: NeilBrown , Trond Myklebust , kinglongmee@gmail.com Subject: [PATCH 1/6 v6] fs_pin: Initialize value for fs_pin explicitly References: <5581256E.70505@gmail.com> In-Reply-To: <5581256E.70505@gmail.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Without initialized, done in fs_pin at stack space may contains strange value. v3, v4, v5, Adds macro for header file Signed-off-by: Kinglong Mee --- include/linux/fs_pin.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/fs_pin.h b/include/linux/fs_pin.h index 3886b3b..0dde7b7 100644 --- a/include/linux/fs_pin.h +++ b/include/linux/fs_pin.h @@ -1,3 +1,6 @@ +#ifndef _LINUX_FS_PIN_H +#define _LINUX_FS_PIN_H + #include struct fs_pin { @@ -16,9 +19,12 @@ static inline void init_fs_pin(struct fs_pin *p, void (*kill)(struct fs_pin *)) INIT_HLIST_NODE(&p->s_list); INIT_HLIST_NODE(&p->m_list); p->kill = kill; + p->done = 0; } void pin_remove(struct fs_pin *); void pin_insert_group(struct fs_pin *, struct vfsmount *, struct hlist_head *); void pin_insert(struct fs_pin *, struct vfsmount *); void pin_kill(struct fs_pin *); + +#endif