From patchwork Mon Jul 27 03:06:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 6867921 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7AB3B9F380 for ; Mon, 27 Jul 2015 03:07:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A091D2052C for ; Mon, 27 Jul 2015 03:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F0A920529 for ; Mon, 27 Jul 2015 03:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755292AbbG0DHE (ORCPT ); Sun, 26 Jul 2015 23:07:04 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:35850 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755269AbbG0DHE (ORCPT ); Sun, 26 Jul 2015 23:07:04 -0400 Received: by pdjr16 with SMTP id r16so44418051pdj.3; Sun, 26 Jul 2015 20:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=NBsGRxMyIpNyCe9dysXCQXNDWdOsO7JFnTDcKxXbrus=; b=yQfCbIOMGfFUtFCOUSUBPHm1VzauvOQApF2OreVaT6xljZ7pWSvcWv0djzHhGAU5fN NJmItVzlOnXWsb366bU8LDrFzIjsZ4QTpcFZImNGYzVTNJW9ZuimXGgpiwuIqPzjqzKT KS6pqiz4xBhiSvdYw3j1nFwTDSBZSddTrxywdzsVMZ1zaTDGje5EOvV7X1vyRhGIG79r 0m9njG39TCU9uLInu6VKYlqHueHvryP29UhAgwDXpOnafq9BAwt0ZsmZ/Kq4aoyaN1IN sgM5fyJL+BbsbnK9jIC8quUlhG2ErWPdbnpnLRShhSK/P7+KPI7FR0Aob1krl4LdFXIV O/sg== X-Received: by 10.70.63.37 with SMTP id d5mr63721283pds.162.1437966422748; Sun, 26 Jul 2015 20:07:02 -0700 (PDT) Received: from [192.168.99.25] ([104.143.41.79]) by smtp.googlemail.com with ESMTPSA id y1sm26367830pdy.2.2015.07.26.20.06.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jul 2015 20:07:02 -0700 (PDT) Message-ID: <55B5A04D.8090905@gmail.com> Date: Mon, 27 Jul 2015 11:06:53 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "J. Bruce Fields" , Al Viro CC: "linux-nfs@vger.kernel.org" , linux-fsdevel@vger.kernel.org, NeilBrown , Trond Myklebust , kinglongmee@gmail.com Subject: [PATCH 1/9 v8] fs_pin: Initialize value for fs_pin explicitly References: <55B5A012.1030006@gmail.com> In-Reply-To: <55B5A012.1030006@gmail.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Without initialized, done in fs_pin at stack space may contains strange value. v8, same as v3 Adds macro for header file Signed-off-by: Kinglong Mee Reviewed-by: NeilBrown --- include/linux/fs_pin.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/fs_pin.h b/include/linux/fs_pin.h index 3886b3b..0dde7b7 100644 --- a/include/linux/fs_pin.h +++ b/include/linux/fs_pin.h @@ -1,3 +1,6 @@ +#ifndef _LINUX_FS_PIN_H +#define _LINUX_FS_PIN_H + #include struct fs_pin { @@ -16,9 +19,12 @@ static inline void init_fs_pin(struct fs_pin *p, void (*kill)(struct fs_pin *)) INIT_HLIST_NODE(&p->s_list); INIT_HLIST_NODE(&p->m_list); p->kill = kill; + p->done = 0; } void pin_remove(struct fs_pin *); void pin_insert_group(struct fs_pin *, struct vfsmount *, struct hlist_head *); void pin_insert(struct fs_pin *, struct vfsmount *); void pin_kill(struct fs_pin *); + +#endif