From patchwork Fri Jul 29 17:45:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peng Tao X-Patchwork-Id: 1021572 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6THjpHx029974 for ; Fri, 29 Jul 2011 17:45:51 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751320Ab1G2Rpu (ORCPT ); Fri, 29 Jul 2011 13:45:50 -0400 Received: from mail-vx0-f174.google.com ([209.85.220.174]:47608 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816Ab1G2Rpu convert rfc822-to-8bit (ORCPT ); Fri, 29 Jul 2011 13:45:50 -0400 Received: by vxh35 with SMTP id 35so2860074vxh.19 for ; Fri, 29 Jul 2011 10:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=YJ6YjyZxpunWX55+wR3xnV16D4LytnseAn5w1kAYfs8=; b=LV3lshScyC524lYJy/tFnvWiDfxswjwZevreQCIC+NWYZgraUz2jsqz7yrVJy2/ZHU I1ICU47YJNU2YRlwR6Ye2YKJIpIrNdIS7sMZUL9HYDHwD4A8JzUXH5wDc2r+B/EMdsnX sAFSQdudIt49Ez4gO7gg+vu4961a16m2ytnhg= Received: by 10.52.71.163 with SMTP id w3mr1668038vdu.394.1311961549193; Fri, 29 Jul 2011 10:45:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.160.225 with HTTP; Fri, 29 Jul 2011 10:45:29 -0700 (PDT) In-Reply-To: <20110729155136.GB28306@infradead.org> References: <1311874276-1386-1-git-send-email-rees@umich.edu> <20110729155136.GB28306@infradead.org> From: Peng Tao Date: Sat, 30 Jul 2011 01:45:29 +0800 Message-ID: Subject: Re: [PATCH v4 00/27] add block layout driver to pnfs client To: Christoph Hellwig Cc: Jim Rees , Trond Myklebust , linux-nfs@vger.kernel.org, peter honeyman Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 29 Jul 2011 17:45:51 +0000 (UTC) Hi, Christoph, On Fri, Jul 29, 2011 at 11:51 PM, Christoph Hellwig wrote: > How well is the I/O code tested?  It's a full reimplementation of > code full of nasty traps.  Did you run xfstests over it?  It supports > nfs, so pointing it to a pnfs share should probably just work. We have been testing the code with cthon04 for some time and all cased are passed since the earliest version. And I just had a try with xfstests. It seems it does not support NFSv4 right now. I had to modify common.rc to make "./check -nfs" runable. Otherwise it failed with: common.rc: Error: $TEST_DEV (10.244.82.74:/s4fs1/) is not a MOUNTED nfs filesystem I tried mounting TEST_DIR both w/ and w/o pnfs. The same errors. After fixing common.rc, "./check -nfs" can run but failed and stopped at case 088. Both pnfs block and NFSv4 failed at the same case. Did anyone run xfstests over NFSv4 before? I'm wondering whether it is a regression or if case 088 is valid for NFSv4. 088 - output mismatch (see 088.out.bad) --- 088.out 2011-07-29 07:33:58.180218573 -0400 +++ 088.out.bad 2011-07-29 08:50:55.242319901 -0400 @@ -1,9 +1,2 @@ QA output created by 088 -access(TEST_DIR/t_access, 0) returns 0 -access(TEST_DIR/t_access, R_OK) returns 0 -access(TEST_DIR/t_access, W_OK) returns 0 -access(TEST_DIR/t_access, X_OK) returns -1 -access(TEST_DIR/t_access, R_OK | W_OK) returns 0 -access(TEST_DIR/t_access, R_OK | X_OK) returns -1 -access(TEST_DIR/t_access, W_OK | X_OK) returns -1 -access(TEST_DIR/t_access, R_OK | W_OK | X_OK) returns -1 +fchown: Invalid argument