From patchwork Thu Feb 3 19:41:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 530431 X-Patchwork-Delegate: Trond.Myklebust@netapp.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p13Jg6ku011355 for ; Thu, 3 Feb 2011 19:42:07 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756563Ab1BCTmE (ORCPT ); Thu, 3 Feb 2011 14:42:04 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:10486 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756491Ab1BCTmD (ORCPT ); Thu, 3 Feb 2011 14:42:03 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id B4C3E9403D; Thu, 3 Feb 2011 20:41:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id B224E9403B; Thu, 3 Feb 2011 20:41:05 +0100 (CET) Date: Thu, 3 Feb 2011 20:41:05 +0100 (CET) From: Jesper Juhl To: Trond Myklebust cc: Milton Miller , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Brown , bfields@fieldses.org Subject: Re: [PATCH] Fix size argument to memset call in nfsacl_encode In-Reply-To: <1296761330.3015.22.camel@heimdal.trondhjem.org> Message-ID: References: <1296761330.3015.22.camel@heimdal.trondhjem.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 03 Feb 2011 19:42:07 +0000 (UTC) diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c index 84c27d6..ec0f277 100644 --- a/fs/nfs_common/nfsacl.c +++ b/fs/nfs_common/nfsacl.c @@ -117,7 +117,6 @@ int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode, * invoked in contexts where a memory allocation failure is * fatal. Fortunately this fake ACL is small enough to * construct on the stack. */ - memset(acl2, 0, sizeof(acl2)); posix_acl_init(acl2, 4); /* Insert entries in canonical order: other orders seem