From patchwork Sat Nov 18 18:32:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris Ostrovsky X-Patchwork-Id: 10064907 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 17B9A60230 for ; Sat, 18 Nov 2017 18:32:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0BACA29990 for ; Sat, 18 Nov 2017 18:32:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F25A329A6B; Sat, 18 Nov 2017 18:32:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1D8029990 for ; Sat, 18 Nov 2017 18:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423324AbdKRScS (ORCPT ); Sat, 18 Nov 2017 13:32:18 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:34377 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423317AbdKRScS (ORCPT ); Sat, 18 Nov 2017 13:32:18 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vAIIWBcN025060 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Nov 2017 18:32:12 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vAIIWBxL027844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Nov 2017 18:32:11 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vAIIWAiK005929; Sat, 18 Nov 2017 18:32:10 GMT Received: from [10.39.244.8] (/10.39.244.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 18 Nov 2017 10:32:10 -0800 Subject: Re: Commit fcd8843c40 breaks old compilers To: Trond Myklebust , "Anna.Schumaker@Netapp.com" Cc: "linux-kernel@vger.kernel.org" , "linux-nfs@vger.kernel.org" References: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com> <1511026783.10238.2.camel@primarydata.com> <49fec52f-229a-4657-a80d-d1a40a9d38e4@oracle.com> <1511028750.14386.1.camel@primarydata.com> From: Boris Ostrovsky Message-ID: Date: Sat, 18 Nov 2017 13:32:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511028750.14386.1.camel@primarydata.com> Content-Language: en-US X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/18/2017 01:12 PM, Trond Myklebust wrote: > > Sigh.... OK, how about something like the following then: > > { .data = { 0xff, 0xff, 0xff, 0xff, 0 }, } > Yes, this does build. -boris --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index 54fd56d..daa6085 100644 --- a/fs/nfs/nfs4state.c +++ b/fs/nfs/nfs4state.c @@ -71,8 +71,7 @@ }; const nfs4_stateid invalid_stateid = { { - .seqid = cpu_to_be32(0xffffffffU), - .other = { 0 }, + .data = { 0xff, 0xff, 0xff, 0xff, 0 }, }, .type = NFS4_INVALID_STATEID_TYPE, };