| Message ID | f6c87857690a66e7f1ee684c755f6c97d8913d64.1742919341.git.trond.myklebust@hammerspace.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Ensure that ENETUNREACH terminates state recovery | expand |
On Tue, 2025-03-25 at 12:17 -0400, trondmy@kernel.org wrote: > From: Trond Myklebust <trond.myklebust@hammerspace.com> > > The autobind setting was supposed to be determined in rpc_create(), > since commit c2866763b402 ("SUNRPC: use sockaddr + size when creating > remote transport endpoints"). > Should this have: Fixes: c2866763b402 ("SUNRPC: use sockaddr + size when creating remote transport endpoints") ? Though I guess that commit is old enough that maybe it doesn't matter. > Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> > --- > net/sunrpc/clnt.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > index 1cfaf93ceec1..6f75862d9782 100644 > --- a/net/sunrpc/clnt.c > +++ b/net/sunrpc/clnt.c > @@ -270,9 +270,6 @@ static struct rpc_xprt *rpc_clnt_set_transport(struct rpc_clnt *clnt, > old = rcu_dereference_protected(clnt->cl_xprt, > lockdep_is_held(&clnt->cl_lock)); > > - if (!xprt_bound(xprt)) > - clnt->cl_autobind = 1; > - > clnt->cl_timeout = timeout; > rcu_assign_pointer(clnt->cl_xprt, xprt); > spin_unlock(&clnt->cl_lock); Reviewed-by: Jeff Layton <jlayton@kernel.org>
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 1cfaf93ceec1..6f75862d9782 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -270,9 +270,6 @@ static struct rpc_xprt *rpc_clnt_set_transport(struct rpc_clnt *clnt, old = rcu_dereference_protected(clnt->cl_xprt, lockdep_is_held(&clnt->cl_lock)); - if (!xprt_bound(xprt)) - clnt->cl_autobind = 1; - clnt->cl_timeout = timeout; rcu_assign_pointer(clnt->cl_xprt, xprt); spin_unlock(&clnt->cl_lock);