From patchwork Tue Feb 12 21:28:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 10808729 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91A971390 for ; Tue, 12 Feb 2019 21:41:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F74D2C1B0 for ; Tue, 12 Feb 2019 21:41:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 72E942C1B3; Tue, 12 Feb 2019 21:41:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1B01B2C1B2 for ; Tue, 12 Feb 2019 21:41:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DC244202E5323; Tue, 12 Feb 2019 13:41:28 -0800 (PST) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=dan.j.williams@intel.com; receiver=linux-nvdimm@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E74F1201B0448 for ; Tue, 12 Feb 2019 13:41:26 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2019 13:41:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,362,1544515200"; d="scan'208";a="142892139" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by fmsmga002.fm.intel.com with ESMTP; 12 Feb 2019 13:41:26 -0800 Subject: [ndctl PATCH 0/8] Improve support + testing for labels + info-blocks From: Dan Williams To: linux-nvdimm@lists.01.org Date: Tue, 12 Feb 2019 13:28:48 -0800 Message-ID: <155000692826.348282.2795434657787204298.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-2-gc94f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP As noted in the kernel patches for this issue: Lately Linux has encountered platforms that collide Persistent Memory regions between each other, specifically cases where ->start_pad needed to be non-zero. This lead to commit ae86cbfef381 "libnvdimm, pfn: Pad pfn namespaces relative to other regions". That commit allowed namespaces to be mapped with devm_memremap_pages(). However dax operations on those configurations currently fail if attempted within the ->start_pad range because pmem_device->data_offset was still relative to raw resource base not relative to the section aligned resource range mapped by devm_memremap_pages(). Luckily __bdev_dax_supported() caught these failures and simply disabled dax. However, to fix this situation a non-backwards compatible change needs to be made to the interpretation of the nd_pfn info-block. ->start_pad needs to be accounted in ->map.map_offset (formerly ->data_offset), and ->map.map_base (formerly ->phys_addr) needs to be adjusted to the section aligned resource base used to establish ->map.map formerly (formerly ->virt_addr). Towards preventing similar bugs in this area introduce a regression test "test/collide.sh" to validate support for pre- and post-fixed kernels. In the course of developing this test a few missing capabilities and fixes also surfaced. --- Dan Williams (8): ndctl/dimm: Add 'flags' field to read-labels output ndctl/dimm: Add --human support to read-labels ndctl/build: Drop -Wpointer-arith ndctl/namespace: Add read-info-block command ndctl/test: Update dax-dev to handle multiple e820 ranges ndctl/test: Make dax.sh more robust vs small namespaces ndctl/namespace: Always zero info-blocks ndctl/test: Test inter-region collision handling configure.ac | 1 ndctl/action.h | 1 ndctl/builtin.h | 1 ndctl/check.c | 20 -- ndctl/dimm.c | 21 ++- ndctl/namespace.c | 416 +++++++++++++++++++++++++++++++++++++++++++++++++- ndctl/namespace.h | 51 ++++++ ndctl/ndctl.c | 1 test/Makefile.am | 1 test/collide.sh | 226 +++++++++++++++++++++++++++ test/dax-dev.c | 17 ++ test/dax.sh | 4 test/fsdax-info0.xxd | 11 + test/fsdax-info1.xxd | 11 + test/fsdax-info2.xxd | 11 + test/fsdax-info3.xxd | 11 + util/fletcher.h | 1 util/size.h | 1 18 files changed, 763 insertions(+), 43 deletions(-) create mode 100755 test/collide.sh create mode 100644 test/fsdax-info0.xxd create mode 100644 test/fsdax-info1.xxd create mode 100644 test/fsdax-info2.xxd create mode 100644 test/fsdax-info3.xxd